Side by Side Diff: chrome/content/survey.xul
Issue 8382011:
Applied changes from emailed code review (Closed)
Patch Set: Applied remaining changes
Created Sept. 26, 2012, 9:02 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« chrome/content/survey.js ('k')
|
chrome/locale/en-US/survey.dtd » ('j')
|
chrome/skin/survey.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 <?xml version="1.0"?> | 1 <?xml version="1.0"?> |
| 2 | 2 |
| 3 <!-- This Source Code Form is subject to the terms of the Mozilla Public | 3 <!-- This Source Code Form is subject to the terms of the Mozilla Public |
| 4 - License, v. 2.0. If a copy of the MPL was not distributed with this file, | 4 - License, v. 2.0. If a copy of the MPL was not distributed with this file, |
| 5 - You can obtain one at http://mozilla.org/MPL/2.0/. --> | 5 - You can obtain one at http://mozilla.org/MPL/2.0/. --> |
| 6 | 6 |
| 7 <?xml-stylesheet type="text/css" href="chrome://global/skin/global.css"?> | 7 <!DOCTYPE overlay SYSTEM "chrome://url-fixer/locale/survey.dtd"> |
| 8 <?xml-stylesheet type="text/css" href="chrome://url-fixer/skin/survey.css"?> | |
| 9 <!DOCTYPE overlay SYSTEM "chrome://url-fixer/locale/locale.dtd"> | |
| 10 <panel | 8 <panel |
| 11 xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" | 9 xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" |
| 12 id="survey" | 10 id="url-fixer-survey" |
| 11 title="&urlfixer.survey.title;" | |
| 13 type="arrow" | 12 type="arrow" |
| 14 orient="vertical" | 13 orient="vertical" |
| 15 onblur="window.close();" | |
| 16 windowtype="urlfixer:survey"> | 14 windowtype="urlfixer:survey"> |
| 17 <script type="text/javascript" src="common.js"/> | |
| 18 <script type="text/javascript" src="survey.js"/> | |
| 19 <hbox> | 15 <hbox> |
| 20 <vbox> | 16 <vbox> |
| 21 <image id="icon"/> | 17 <image id="icon"/> |
|
Wladimir Palant
2012/09/28 09:29:34
You are adding this to a large document updated by
| |
| 22 </vbox> | 18 </vbox> |
| 23 <vbox id="question_container" pack="center"> | 19 <vbox id="question_container" pack="center"> |
| 24 <description id="question"></description> | 20 <description id="question">&urlfixer.survey.question;</description> |
| 25 <description id="note"></description> | 21 <description>&urlfixer.survey.note;</description> |
| 26 </vbox> | 22 </vbox> |
| 27 </hbox> | 23 </hbox> |
| 28 <hbox id="actions"> | 24 <hbox id="actions"> |
| 29 <button id="accept" dlgtype="accept" onclick="onAccept();window.close();"/> | 25 <space flex="1"/> |
|
Wladimir Palant
2012/09/28 09:29:34
You probably meant <spacer>. Either way, just add
| |
| 30 <spacer flex="1"/> | 26 <button id="accept-button" dlgtype="accept">&urlfixer.survey.accept;</button > |
| 31 <button id="decline" dlgtype="cancel" onclick="onCancel();window.close();"/> | 27 <button id="cancel-button" dlgtype="cancel">&urlfixer.survey.decline;</butto n> |
|
Wladimir Palant
2012/09/28 09:29:34
dlgtype attribute only makes sense in dialogs.
| |
| 32 </hbox> | 28 </hbox> |
| 33 </panel> | 29 </panel> |
| OLD | NEW |
« no previous file with comments
|
« chrome/content/survey.js ('k')
|
chrome/locale/en-US/survey.dtd » ('j')
|
chrome/skin/survey.css » ('J')
