Unified Diff: chrome/content/survey.xul
Issue 8382011:
Applied changes from emailed code review (Closed)
Patch Set: Applied remaining changes
Created Sept. 26, 2012, 9:02 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« chrome/content/survey.js ('k')
|
chrome/locale/en-US/survey.dtd » ('j')
|
chrome/skin/survey.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: chrome/content/survey.xul |
| =================================================================== |
| --- a/chrome/content/survey.xul |
| +++ b/chrome/content/survey.xul |
| @@ -4,30 +4,26 @@ |
| - License, v. 2.0. If a copy of the MPL was not distributed with this file, |
| - You can obtain one at http://mozilla.org/MPL/2.0/. --> |
| -<?xml-stylesheet type="text/css" href="chrome://global/skin/global.css"?> |
| -<?xml-stylesheet type="text/css" href="chrome://url-fixer/skin/survey.css"?> |
| -<!DOCTYPE overlay SYSTEM "chrome://url-fixer/locale/locale.dtd"> |
| +<!DOCTYPE overlay SYSTEM "chrome://url-fixer/locale/survey.dtd"> |
| <panel |
| xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" |
| - id="survey" |
| + id="url-fixer-survey" |
| + title="&urlfixer.survey.title;" |
| type="arrow" |
| orient="vertical" |
| - onblur="window.close();" |
| windowtype="urlfixer:survey"> |
| - <script type="text/javascript" src="common.js"/> |
| - <script type="text/javascript" src="survey.js"/> |
| <hbox> |
| <vbox> |
| <image id="icon"/> |
|
Wladimir Palant
2012/09/28 09:29:34
You are adding this to a large document updated by
|
| </vbox> |
| <vbox id="question_container" pack="center"> |
| - <description id="question"></description> |
| - <description id="note"></description> |
| + <description id="question">&urlfixer.survey.question;</description> |
| + <description>&urlfixer.survey.note;</description> |
| </vbox> |
| </hbox> |
| <hbox id="actions"> |
| - <button id="accept" dlgtype="accept" onclick="onAccept();window.close();"/> |
| - <spacer flex="1"/> |
| - <button id="decline" dlgtype="cancel" onclick="onCancel();window.close();"/> |
| + <space flex="1"/> |
|
Wladimir Palant
2012/09/28 09:29:34
You probably meant <spacer>. Either way, just add
|
| + <button id="accept-button" dlgtype="accept">&urlfixer.survey.accept;</button> |
| + <button id="cancel-button" dlgtype="cancel">&urlfixer.survey.decline;</button> |
|
Wladimir Palant
2012/09/28 09:29:34
dlgtype attribute only makes sense in dialogs.
|
| </hbox> |
| </panel> |
« no previous file with comments
|
« chrome/content/survey.js ('k')
|
chrome/locale/en-US/survey.dtd » ('j')
|
chrome/skin/survey.css » ('J')
