Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: firstRun.js

Issue 8403145: First attempt at creating a first-run page (Closed)
Patch Set: Created Oct. 17, 2012, 2:44 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « firstRun.html ('k') | skin/firstRun.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: firstRun.js
===================================================================
--- a/firstRun.js
+++ b/firstRun.js
@@ -7,23 +7,27 @@ function init()
{
// Choose a share text variant randomly
var variant = Math.floor(Math.random() * 2) + 1;
document.documentElement.setAttribute("share-variant", variant);
// Set up page title
var titleId = (backgroundPage.isFirstRun ? "firstRun_title_install" : "firstRun_title_update");
var pageTitle = chrome.i18n.getMessage(titleId);
- document.title = document.getElementById("title").textContent = pageTitle;
+ document.title = document.getElementById("title-main").textContent = pageTitle;
+
+ // Only show changelog link on the update page
+ if (backgroundPage.isFirstRun)
+ document.getElementById("title-changelog").style.display = "none";
// Set up URLs
- var versionID = chrome.app.getDetails().version.split(".").slice(0, 2).join("");
- setLinks("improvementsFeature", "https://adblockplus.org/releases/adblock-plus-" + versionID + "-for-google-chrome-released");
- setLinks("acceptableAdsExplanation", getDocLink("acceptable_ads"),
- getDocLink("acceptable_ads", "criteria"), backgroundPage.openOptions);
+ var versionId = chrome.app.getDetails().version.split(".").slice(0, 2).join("");
+ setLinks("title-changelog", "https://adblockplus.org/releases/adblock-plus-" + versionId + "-for-google-chrome-released");
+ setLinks("acceptableAdsExplanation", getDocLink("acceptable_ads", "criteria"),
+ backgroundPage.openOptions);
var facebookLinks = document.getElementsByClassName("share-facebook");
for (var i = 0; i < facebookLinks.length; i++)
facebookLinks[i].href = getDocLink("facebook") + "&variant=" + variant;
var twitterLinks = document.getElementsByClassName("share-twitter");
for (var i = 0; i < twitterLinks.length; i++)
twitterLinks[i].href = getDocLink("twitter") + "&variant=" + variant;
« no previous file with comments | « firstRun.html ('k') | skin/firstRun.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld