Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/options.js

Issue 8433028: added hook function to appIntegration to handle function-overwrites from other extensions (Closed)
Patch Set: applied changes from code review Created Sept. 26, 2012, 1:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/content/tests/qunit.css » ('j') | lib/appIntegration.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/options.js
===================================================================
--- a/chrome/content/options.js
+++ b/chrome/content/options.js
@@ -73,7 +73,7 @@
whitelist.sort();
// Add the rules to the list
- if(ruleList.length > 0)
+ if (ruleList.length > 0)
{
for (let i = 0; i < ruleList.length; i++)
{
@@ -102,7 +102,7 @@
ruleListElement.appendChild(option);
}
- if(whitelist.length > 0)
+ if (whitelist.length > 0)
{
for (let i = 0; i < whitelist.length; i++)
{
@@ -142,10 +142,15 @@
let list = E(btn.getAttribute("_list"));
let items = list.selectedItems;
+ let {onWhitelistEntryRemoved} = require("rules");
+
for (let i = items.length - 1; i >= 0; i--)
{
let searchString = items[i].getAttribute("value");
delete Prefs[pref][searchString];
+
+ if (pref == "whitelist")
+ onWhitelistEntryRemoved(searchString);
}
Prefs[pref] = JSON.parse(JSON.stringify(Prefs[pref]));
}
« no previous file with comments | « no previous file | chrome/content/tests/qunit.css » ('j') | lib/appIntegration.js » ('J')

Powered by Google App Engine
This is Rietveld