ABP/Android subscription list

src/org/adblockplus/android/SubscriptionParser.java

 package org.adblockplus.android;
 
 import java.util.List;
 
 import org.xml.sax.Attributes;
 import org.xml.sax.SAXException;
 import org.xml.sax.helpers.DefaultHandler;
 
 class SubscriptionParser extends DefaultHandler
 {
   private static final String SUBSCRIPTION = "subscription";
   private static final String TITLE = "title";
   private static final String SPECIALIZATION = "specialization";
   private static final String URL = "url";
   private static final String HOMEPAGE = "homepage";
   private static final String PREFIXES = "prefixes";
   private static final String AUTHOR = "author";
 
   private List<Subscription> subscriptions;

[Felix Dahlke, 2012/11/13 09:58:12]

How about naming this "currentSubscription" to highlight that it's the one being
currently parsed?

[Andrey Novikov, 2012/11/14 07:13:59]

Do not see any reason but done.

-  private Subscription subscription;
+  private Subscription currentSubscription;
 
   public SubscriptionParser(List<Subscription> subscriptions)
   {
     super();
     this.subscriptions = subscriptions;
   }
 
   @Override
   public void startElement(String uri, String localName, String qName, Attributes attributes) throws SAXException
   {
     if (localName.equalsIgnoreCase(SUBSCRIPTION))
     {
-      subscription = new Subscription();
-      subscription.title = attributes.getValue(TITLE);
-      subscription.specialization = attributes.getValue(SPECIALIZATION);
-      subscription.url = attributes.getValue(URL);
-      subscription.homepage = attributes.getValue(HOMEPAGE);
+      currentSubscription = new Subscription();
+      currentSubscription.title = attributes.getValue(TITLE);
+      currentSubscription.specialization = attributes.getValue(SPECIALIZATION);
+      currentSubscription.url = attributes.getValue(URL);
+      currentSubscription.homepage = attributes.getValue(HOMEPAGE);
       String prefix = attributes.getValue(PREFIXES);
       if (prefix != null)
       {
         String[] prefixes = prefix.split(",");
-        subscription.prefixes = prefixes;
+        currentSubscription.prefixes = prefixes;
       }
-      subscription.author = attributes.getValue(AUTHOR);
+      currentSubscription.author = attributes.getValue(AUTHOR);
     }
     super.startElement(uri, localName, qName, attributes);
   }
 
   @Override
   public void endElement(String uri, String localName, String qName) throws SAXException
   {
     if (localName.equalsIgnoreCase(SUBSCRIPTION))
     {
-      if (subscriptions != null && subscription != null)
+      if (subscriptions != null && currentSubscription != null)
       {
-        subscriptions.add(subscription);
+        subscriptions.add(currentSubscription);
       }
-      subscription = null;
+      currentSubscription = null;
     }
     super.endElement(uri, localName, qName);
   }
 }