Integrated URL Fixer into Adblock Plus

chrome/content/ui/typoSettings.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 let {Prefs} = require("prefs");
 
 let TypoActions =
 {
   init: function()
   {
     TypoActions.updateState();
     TypoActions.updateList();
     
     Prefs.addListener(TypoActions.onPrefChange);
     window.addEventListener("unload", function() Prefs.removeListener(TypoActions.onPrefChange), false);
   },
   
   onPrefChange: function(name)
   {
     if (name == "whitelist")
       TypoActions.updateList();
     else if (name == "correctTypos")
       TypoActions.updateState();
-    else if (name == "whitelist")
-      TypoActions.updateList();

[Wladimir Palant, 2012/11/09 13:20:51]

Are you making extra sure to handle the whitelist preference? :)

   },
   
   setEnabled: function(checked)
   {
     Prefs.correctTypos = checked;
   },
   
   onItemSelected: function(list)
   {
     let button = E(list.getAttribute("_removeButton"));
@@ skipping 50 matching lines @@
       option.setAttribute("label", whitelistElement.getAttribute("_emptyLabel"));
 
       whitelistElement.appendChild(option);
     }
   },
   
   updateState: function()
   {
     let enabled = Prefs.correctTypos;
     E("typo_enable").checked = enabled;
-    E("typo_whitelist_container").style.visibility = (enabled) ? "visible" : "hidden";

[Wladimir Palant, 2012/11/09 13:20:51]

Please use .hidden property here, forgot to note that in the previous review.

+    E("typo_whitelist_container").hidden = !enabled;
   }
 };
 
 window.addEventListener("load", function()
 {
   TypoActions.init();
 }, false);