adblockplusopera: Port UI code from Chrome

background.js

 var DownloadableSubscription = require("subscriptionClasses").DownloadableSubscription;
 var WhitelistFilter = require("filterClasses").WhitelistFilter;
 var FilterNotifier = require("filterNotifier").FilterNotifier;
 var FilterStorage = require("filterStorage").FilterStorage;
 var Prefs = require("prefs").Prefs;
 var Synchronizer = require("synchronizer").Synchronizer;
 var Subscription = require("subscriptionClasses").Subscription;
 var SpecialSubscription = require("subscriptionClasses").SpecialSubscription;
 var Utils = require("utils").Utils;
 
@@ skipping 170 matching lines @@
     toolbar.addItem(toolbarButton);
   else
     toolbar.removeItem(toolbarButton);
 }
 
 function getJson(url)
 {
   var request = new XMLHttpRequest();
   request.open("GET", url, false);
   request.responseType = "json";
   request.send();

[Wladimir Palant, 2012/10/17 10:17:14]

What happens if the file doesn't exist? Won't this throw an exception?

[Felix Dahlke, 2012/10/18 08:08:46]

Yes, you're right. Done.

   return request.response;
 }
 
 function loadMessagesForLocale(locale)
 {
   var messagesFileName = "messages.json";
   var messagesPath;
   if (locale)
     messagesPath = "locales/" + locale + "/" + messagesFileName;
   else
     messagesPath = messagesFileName;
 
   var messages = getJson(messagesPath);
+  if (!messages)
+  {
+    console.error("Failed to load messages for locale "
+                  + (locale ? locale : "default"));
+    return;
+  }
+
   for (var i in messages)
     i18nMessages[i] = messages[i];
 }
 
 function loadI18nMessages()

[Wladimir Palant, 2012/10/17 10:17:14]

From the look of it, this function will never load en-gb strings.

[Felix Dahlke, 2012/10/18 08:08:46]

It does, that's the locale I use.

 {
+  // Could be parsed from config.xml
+  var defaultLocale = "en";
+
   i18nMessages = {};
-
-  var baseLocale = "en";

[Wladimir Palant, 2012/10/17 10:17:14]

Is there an easy way to get the default locale from config.xml? Or would we need
to load/parse it?

[Felix Dahlke, 2012/10/18 08:08:46]

Oh, didn't notice it was specified there. I have just dug around a little, it
doesn't seem like there is an easy way to get it though, we'd have to parse
config.xml. Seems worth doing though, what do you think?

-  var language = locale.split("-")[0];

[Wladimir Palant, 2012/10/17 10:17:14]

locale is undefined?

[Felix Dahlke, 2012/10/18 08:08:46]

No, it's a global. It's defined in a locale-specific file "locale.js", I've
described this in update_locales.py. I've added a comment here as well to make
it clear.

-
-  if (baseLocale !== language)
-    loadMessagesForLocale(baseLocale);
-
-  if (locale !== language)

[Wladimir Palant, 2012/10/17 10:17:14]

What's the point of this check? Shouldn't we always load the strings for the
language?

[Felix Dahlke, 2012/10/18 08:08:46]

"language" is just the language part, without the country. e.g. just "en".

Locale loading works like this:

1. We first load messages for the base locale, "en"
2. We then load messages for the country part of the user's locale, which is
"en" in the case of "en-gb". So if baseLocale equals languageLocale, we skip it.
3. Finally, we load messages for the user's actual locale. If there is no
country part, we don't bother, because we already have the messages for the
language part.

-    loadMessagesForLocale(language);
-
+  loadMessagesForLocale(defaultLocale);
   loadMessagesForLocale();

[Wladimir Palant, 2012/10/17 10:17:14]

Locale-independent messages.json? Sounds pointless.

[Felix Dahlke, 2012/10/18 08:08:46]

messages.json exists once for each locale and is loaded using Opera's mechanism.
See update_locales.py for more details.

 }
 
 setDefaultOptions();
 createToolbarButton();
 refreshToolbarButton();
 loadI18nMessages();