adblockpluschrome: Open share page in lightbox

firstRun.js

 var backgroundPage = chrome.extension.getBackgroundPage();
 var require = backgroundPage.require;
 var Prefs = require("prefs").Prefs;
 var Utils = require("utils").Utils;
 
+function openSharePopup(url)
+{
+  var iframe = document.getElementById("share-popup");
+  var glassPane = document.getElementById("glass-pane");
+
+  var popupLoadListener = function()
+  {
+    iframe.className = "visible";
+
+    var popupCloseListener = function()
+    {
+      iframe.className = glassPane.className = "";
+      document.removeEventListener("click", popupCloseListener);
+    }

[Wladimir Palant, 2012/10/25 10:45:03]

Missing semicolon?

[Felix Dahlke, 2012/10/25 12:00:51]

Yes, ouch.

+    document.addEventListener("click", popupCloseListener, false);
+    iframe.removeEventListener("load", popupLoadListener);
+  };
+
+  iframe.addEventListener("load", popupLoadListener, false);
+  iframe.src = url;
+  glassPane.className = "visible";

[Wladimir Palant, 2012/10/25 10:45:03]

Does it still work if you close the popup and then open it again?

[Felix Dahlke, 2012/10/25 12:00:51]

Sure.

+}
+
+function initSocialLinks(variant)
+{
+  var networks = ["twitter", "facebook"];
+  networks.forEach(function(network)
+  {
+    var links = document.getElementsByClassName("share-" + network);
+    for (var i = 0; i < links.length; i++)

[Wladimir Palant, 2012/10/25 10:45:03]

I consider it acceptable to omit brackets if the for loop body only spans one
line - for multiple lines like here it really hurts readability however, even
though syntactically there is no issue.

[Felix Dahlke, 2012/10/25 12:00:51]

OK, seems appropriate.

+      links[i].addEventListener("click", function(e)
+      {
+        e.preventDefault();
+//        openSharePopup(getDocLink(network) + "&variant=" + variant);
+        openSharePopup("http://localhost:8000");

[Wladimir Palant, 2012/10/25 10:45:03]

Debug code apparently.

[Felix Dahlke, 2012/10/25 12:00:51]

Double ouch.

+      }, false);
+  });
+}
+
 function init()
 {
   // Choose a share text variant randomly
   var variant = Math.floor(Math.random() * 2) + 1;
   document.documentElement.setAttribute("share-variant", variant);
 
   // Set up page title
   var titleId = (backgroundPage.isFirstRun ? "firstRun_title_install" : "firstRun_title_update");
   var pageTitle = i18n.getMessage(titleId);
   document.title = document.getElementById("title-main").textContent = pageTitle;
 
   // Only show changelog link on the update page
   if (backgroundPage.isFirstRun)
     document.getElementById("title-changelog").style.display = "none";
 
   // Set up URLs
   var versionId = chrome.app.getDetails().version.split(".").slice(0, 2).join("");
   setLinks("title-changelog", "https://adblockplus.org/releases/adblock-plus-" + versionId + "-for-google-chrome-released");
   setLinks("acceptableAdsExplanation", getDocLink("acceptable_ads", "criteria"),
       backgroundPage.openOptions);
 
-  var facebookLinks = document.getElementsByClassName("share-facebook");
-  for (var i = 0; i < facebookLinks.length; i++)
-    facebookLinks[i].href = getDocLink("facebook") + "&variant=" + variant;
-
-  var twitterLinks = document.getElementsByClassName("share-twitter");
-  for (var i = 0; i < twitterLinks.length; i++)
-    twitterLinks[i].href = getDocLink("twitter") + "&variant=" + variant;
+  initSocialLinks(variant);
 
   var donateLink = document.getElementById("share-donate");
   donateLink.href = getDocLink("donate") + "&variant=" + variant;
 }
 window.addEventListener("load", init, false);
 
 function setLinks(id)
 {
   var element = document.getElementById(id);
   if (!element)
@@ skipping 14 matching lines @@
     }
   }
 }
 
 function getDocLink(page, anchor)
 {
   return Prefs.documentation_link
               .replace(/%LINK%/g, page)
               .replace(/%LANG%/g, Utils.appLocale) + (anchor ? "#" + anchor : "");
 }