adblockpluschrome: Open share page in lightbox

firstRun.js

 var backgroundPage = chrome.extension.getBackgroundPage();
 var require = backgroundPage.require;
 var Prefs = require("prefs").Prefs;
 var Utils = require("utils").Utils;
 
 function openSharePopup(url)
 {
   var iframe = document.getElementById("share-popup");
   var glassPane = document.getElementById("glass-pane");
 
+  var popupMessageListener = function(event)
+  {
+    if (event.origin !== url)
+      return;
+
+    console.log(event);

[Wladimir Palant, 2012/10/25 13:31:04]

Debug code?

+    iframe.width = event.data.width;
+    iframe.height = event.data.height;
+    window.removeEventListener("message", popupMessageListener);
+  };
+  window.addEventListener("message", popupMessageListener, false);
+
   var popupLoadListener = function()
   {
     iframe.className = "visible";
 
     var popupCloseListener = function()
     {
       iframe.className = glassPane.className = "";
       document.removeEventListener("click", popupCloseListener);
-    }

[Wladimir Palant, 2012/10/25 10:45:03]

Missing semicolon?

[Felix Dahlke, 2012/10/25 12:00:51]

Yes, ouch.

+    };
     document.addEventListener("click", popupCloseListener, false);
     iframe.removeEventListener("load", popupLoadListener);
   };
+  iframe.addEventListener("load", popupLoadListener, false);
 
-  iframe.addEventListener("load", popupLoadListener, false);
   iframe.src = url;
   glassPane.className = "visible";

[Wladimir Palant, 2012/10/25 10:45:03]

Does it still work if you close the popup and then open it again?

[Felix Dahlke, 2012/10/25 12:00:51]

Sure.

 }
 
 function initSocialLinks(variant)
 {
   var networks = ["twitter", "facebook"];
   networks.forEach(function(network)
   {
     var links = document.getElementsByClassName("share-" + network);
     for (var i = 0; i < links.length; i++)

[Wladimir Palant, 2012/10/25 10:45:03]

I consider it acceptable to omit brackets if the for loop body only spans one
line - for multiple lines like here it really hurts readability however, even
though syntactically there is no issue.

[Felix Dahlke, 2012/10/25 12:00:51]

OK, seems appropriate.

+    {
       links[i].addEventListener("click", function(e)
       {
         e.preventDefault();
-//        openSharePopup(getDocLink(network) + "&variant=" + variant);
-        openSharePopup("http://localhost:8000");

[Wladimir Palant, 2012/10/25 10:45:03]

Debug code apparently.

[Felix Dahlke, 2012/10/25 12:00:51]

Double ouch.

+        openSharePopup(getDocLink("share-" + network) + "&variant=" + variant);
       }, false);
+    }
   });
 }
 
 function init()
 {
   // Choose a share text variant randomly
   var variant = Math.floor(Math.random() * 2) + 1;
   document.documentElement.setAttribute("share-variant", variant);
 
   // Set up page title
@@ skipping 39 matching lines @@
     }
   }
 }
 
 function getDocLink(page, anchor)
 {
   return Prefs.documentation_link
               .replace(/%LINK%/g, page)
               .replace(/%LANG%/g, Utils.appLocale) + (anchor ? "#" + anchor : "");
 }