Reports - user usefullness

sitescripts/reports/web/updateReport.py

 # coding: utf-8
 
 # This Source Code is subject to the terms of the Mozilla Public License
 # version 2.0 (the "License"). You can obtain a copy of the License at
 # http://mozilla.org/MPL/2.0/.
 
 import re, os, sys, random
 from urlparse import parse_qsl
 from sitescripts.utils import get_config, get_template, setupStderr
 from sitescripts.web import url_handler
@@ skipping 26 matching lines @@
     return showError('Report does not exist', start_response)
 
   secret = calculateReportSecret(guid)
   if params.get('secret', '') != secret and params.get('secret', '') != calculateReportSecret_compat(guid):
     return showError('Wrong secret value', start_response)
 
   reportData['status'] = params.get('status', '')
   if len(reportData['status']) > 1024:
     reportData['status'] = reportData['status'][:1024]
 
+  if (reportData.get('email', None)):
+    reportData['utility'] = params.get('utility', 0)

[Wladimir Palant, 2012/10/18 15:41:24]

Isn't this value a string? The default value should be a string as well then -
'0' rather than 0.

[Andrey Novikov, 2012/10/18 15:51:29]

Done.

+
   saveReport(guid, reportData)
 
   if params.get('notify', '') and 'email' in reportData:
     email = reportData['email']
     email = re.sub(r' at ', r'@', email)
     email = re.sub(r' dot ', r'.', email)
     if re.match(r'^[\w.%+-]+@[\w.%+-]+(\.[\w.%+-]+)+', email):
       sendUpdateNotification({
         'email': email,
         'url': get_config().get('reports', 'urlRoot') + guid,
         'status': reportData['status'],
       })
 
   newURL = get_config().get('reports', 'urlRoot') + guid
   newURL += '?updated=' + str(int(random.uniform(0, 10000)))
   newURL += '#secret=' + secret
   start_response('302 Found', [('Location', newURL.encode('utf-8'))])
   return []
 
 def showError(message, start_response):
   template = get_template(get_config().get('reports', 'errorTemplate'))
   start_response('400 Processing Error', [('Content-Type', 'application/xhtml+xml; charset=utf-8')])
   return [template.render({'message': message}).encode('utf-8')]