Reports - user usefullness

sitescripts/reports/static/reports.js

 if (typeof localStorage == "undefined")
   window.localStorage = {};
 var templates;
 
 function migrateCookies()
 {
   var cookies = document.cookie.split(/\s*;\s*/);
   for (var i = 0; i < cookies.length; i++)
   {
     if (/^(.*?)=(.*)/.test(cookies[i]))
@@ skipping 33 matching lines @@
 {
   for (var i = 0; i < radio.length; i++)
     radio[i].addEventListener("click", listener, false);
 }
 
 function getCheckedRadio(radio)
 {
   for (var i = 0; i < radio.length; i++)
   {
     if (radio[i].checked)
-      return radio[i]

[Wladimir Palant, 2012/10/23 05:23:28]

Semicolon missing here.

+      return radio[i];
   }
   return undefined;
 }
 
 function saveSecret(guid, secret)
 {
   var secrets = localStorage.secrets;
   if (secrets)
     secrets = JSON.parse(secrets);
   else
@@ skipping 40 matching lines @@
         'Enter new status:' + notifyBox + '<br />' +
         '<textarea id="statusField" name="status" oninput="updateTemplateButtons();"></textarea>' + 
         '<br />Usefulness: <input type="radio" name="usefulness" value="0" checked="checked" /> not established <input type="radio" name="usefulness" value="1" /> useful <input type="radio" name="usefulness" value="-1" /> useless' +
       '</p>' +
       '<div>' +
         '<button id="addTemplateButton" type="button" onclick="addTemplate();">Add as template</button>' +
         '<button id="removeTemplateButton" type="button" onclick="removeTemplate();">Remove template</button>' +
         '<input type="submit" value="Change status"/>' +
       '</div>' +
     '</form>';
+    var radios = document.getElementById("updateForm").elements.usefulness;
     document.getElementById("templatesField").addEventListener("change", function()
     {
       if (this.selectedIndex > 0)
       {
-        var template = this.options[this.selectedIndex].value.split("|");

[Wladimir Palant, 2012/10/23 05:23:28]

.split("|", 2) please - just in case. However, it might be better to use some
character that will definitely not be used in normal template text - how about
"\x00"?

+        var template = this.options[this.selectedIndex].value.split("\1");
         var displayText = template[template.length - 1];
         if (template.length > 1)
-          setRadio(document.getElementById("updateForm").elements.usefulness, template[0]);
+          setRadio(radios, template[0]);
         document.getElementById("statusField").value = displayText;
         var notifyField = document.getElementById("notify");
         if (notifyField)
           notifyField.checked = true;
         updateTemplateButtons();
       }
     }, false);
 
     var statusField = document.getElementById("statusField");
     statusField.value = status;
 
-    var usefulness = document.getElementById("usefulnessCell").getAttribute("value");

[Wladimir Palant, 2012/10/23 05:23:28]

What if there is no usefulnessCell? Note that you might have an old report using
the updated script.

[Andrey Novikov, 2012/10/23 14:15:29]

It's much better to run our one-time all reports update script.

[Wladimir Palant, 2012/10/25 15:12:55]

I don't really like doing that without a very good reason. So I would prefer it
if you fixed this.

-    var radios = document.getElementById("updateForm").elements.usefulness;

[Andrey Novikov, 2012/10/23 14:15:29]

Done.

+    var usefulness = 0;
+    var usefulnessCell = document.getElementById("usefulnessCell");
+    if (usefulnessCell)
+      usefulness = usefulnessCell.getAttribute("value");
     setRadio(radios, usefulness);
     setRadioListener(radios, updateTemplates);
 
     updateTemplates();
     statusField.focus();
   }
 }
 
 function updateTemplates()
 {
   var templatesField = document.getElementById("templatesField");
   while (templatesField.options.length > 1)
     templatesField.remove(1);
   for (var i = 0; i < templates.length; i++)
   {
-    var template = templates[i].split("|");
+    var template = templates[i].split("\1");
     var displayText = template[template.length - 1];
     if (displayText.length > 150)
       displayText = displayText.substr(0, 75) + "..." + displayText.substr(displayText.length - 75, displayText.length);
     if (template.length > 1)
     {
-      usefulnessText = template[0] > 0 ? "useful" : template[0] < 0 ? "useless" : "neutral";

[Wladimir Palant, 2012/10/23 05:23:28]

I don't think that [neutral] is required - we should only add a tag if the
useful/useless information is included.

[Andrey Novikov, 2012/10/23 14:15:29]

Done.

-      displayText = "[" + usefulnessText + "] " + displayText;
-    }  
+      usefulnessText = template[0] > 0 ? "useful" : template[0] < 0 ? "useless" : null;
+      if (usefulnessText != null)
+        displayText = "[" + usefulnessText + "] " + displayText;
+    }
     templatesField.add(new Option(displayText, templates[i], false, false), null);
   }
   updateTemplateButtons();
 }
 
 function updateTemplateButtons()
 {
   var currentText = document.getElementById("statusField").value;
   var usefulnessValue = "0";
   var usefulnessButton = getCheckedRadio(document.getElementById("updateForm").elements.usefulness);
   if (usefulnessButton)
     usefulnessValue = usefulnessButton.value;
 
   var options = document.getElementById("templatesField").options;
   for (var i = 1; i < options.length; i++)
   {
-    var template = options[i].value.split("|");
+    var template = options[i].value.split("\1");
     var text = template[template.length - 1];
     var usefulness = template.length > 1 ? template[0] : "0";
       
     if (text == currentText && usefulness == usefulnessValue)
     {
       document.getElementById("templatesField").selectedIndex = i;
       document.getElementById("addTemplateButton").style.display = "none";
       document.getElementById("removeTemplateButton").style.display = "";
       return;
     }
   }
 
   document.getElementById("templatesField").selectedIndex = 0;
   document.getElementById("addTemplateButton").disabled = !/\S/.test(currentText) || currentText == "unknown";
   document.getElementById("addTemplateButton").style.display = "";
   document.getElementById("removeTemplateButton").style.display = "none";
 }
 
 function addTemplate()
 {
   var usefulnessValue = "0";
   var usefulnessButton = getCheckedRadio(document.getElementById("updateForm").elements.usefulness);
   if (usefulnessButton)
     usefulnessValue = usefulnessButton.value;
 
-  var value =  usefulnessValue + "|" + document.getElementById("statusField").value;
+  var value =  usefulnessValue + "\1" + document.getElementById("statusField").value;
   templates.push(value);
   templates.sort();

[Wladimir Palant, 2012/10/23 05:23:28]

Note that the result of this sort will be: useless, no usefulness set, useful.
That's reasonable I guess...

   localStorage.templates = templates.join("\0");
   updateTemplates();
 }
 
 function removeTemplate()
 {
   var currentText = document.getElementById("statusField").value;
   var usefulnessValue = "0";
   var usefulnessButton = getCheckedRadio(document.getElementById("updateForm").elements.usefulness);
   if (usefulnessButton)
     usefulnessValue = usefulnessButton.value;
   for (var i = 0; i < templates.length; i++)
   {
-    var template = templates[i].split("|");
+    var template = templates[i].split("\1");
     var text = template[template.length - 1];
     var usefulness = template.length > 1 ? template[0] : "0";
     if (text == currentText && usefulness == usefulnessValue)
       templates.splice(i--, 1);
   }
   localStorage.templates = templates.join("\0");
   updateTemplates();
 }
 
 function selectTab(tab)
@@ skipping 157 matching lines @@
       var spans = nodes[j].getElementsByTagName("span");
       for (var k = 0; k < spans.length; k++)
         if (spans[k].hasAttribute("title"))
           spans[k].setAttribute("title", toLocalDate(spans[k].getAttribute("title")));
     }
   }
 }
 
 window.addEventListener("DOMContentLoaded", initTables, false);
 window.addEventListener("DOMContentLoaded", changeDates, false);