Reports - user usefullness

sitescripts/reports/utils.py

 # coding: utf-8
 
 # This Source Code is subject to the terms of the Mozilla Public License
 # version 2.0 (the "License"). You can obtain a copy of the License at
 # http://mozilla.org/MPL/2.0/.
 
 import hashlib, hmac, base64, MySQLdb, os, re, marshal, subprocess
-from sitescripts.utils import get_config, memoize, cached, get_template, sendMail
+from sitescripts.utils import get_config, cached, get_template, sendMail
 
 def getReportSubscriptions(guid):
   cursor = get_db().cursor(MySQLdb.cursors.DictCursor)
   executeQuery(cursor,
               '''SELECT url, hasmatches FROM #PFX#sublists INNER JOIN
               #PFX#subscriptions ON (#PFX#sublists.list = #PFX#subscriptions.id)
               WHERE report = %s''',
               (guid))
   rows = cursor.fetchall()
   cursor.close()
@@ skipping 33 matching lines @@
   cursor = get_db().cursor()
   screenshot = reportData.get('screenshot', None)
   if screenshot != None:
     reportData['hasscreenshot'] = 2 if reportData.get('screenshotEdited', False) else 1
     try:
       saveScreenshot(guid, screenshot)
     except (TypeError, UnicodeEncodeError):
       reportData['hasscreenshot'] = 0
     del reportData['screenshot']
   knownIssues = len(reportData.get('knownIssues', []))
-  contact = getUserId(reportData.get('email', None)) if 'email' in reportData else None

[Wladimir Palant, 2012/10/22 13:32:52]

If 'email' in reportData is True then it means that there is an email attribute
- but it's value can still be None. With your change you will pass that None to
getUserId() which will probably fail. IMHO the old version was correct.

[Andrey Novikov, 2012/10/23 14:15:29]

Done.

+  contact = getUserId(reportData.get('email', None)) if reportData.get('email', None) else None
   dumpstr = marshal.dumps(reportData)
   
   if contact != None and isNew:
     executeQuery(cursor,
                 '''INSERT INTO #PFX#users (id, reports) VALUES (%s, 1) ON DUPLICATE KEY UPDATE reports = reports + 1''',
                 (contact))
   executeQuery(cursor,
               '''INSERT INTO #PFX#reports (guid, type, ctime, site, comment, status, contact, hasscreenshot, knownissues, dump)
                  VALUES (%(guid)s, %(type)s, FROM_UNIXTIME(%(ctime)s), %(site)s, %(comment)s, %(status)s, %(contact)s,
                  %(hasscreenshot)s, %(knownissues)s, %(dump)s) ON DUPLICATE KEY
@@ skipping 31 matching lines @@
          '''DELETE FROM #PFX#reports WHERE guid = %s''',
          (guid))
   get_db().commit()
   file = os.path.join(get_config().get('reports', 'dataPath'), guid[0], guid[1], guid[2], guid[3], guid + '.html')
   if os.path.isfile(file):
     os.remove(file)
   file = os.path.join(get_config().get('reports', 'dataPath'), guid[0], guid[1], guid[2], guid[3], guid + '.png')
   if os.path.isfile(file):
     os.remove(file)
 
-@memoize
+@cached(3600)
 def getUserUsefulnessScore(contact):
   if contact == None:
     return 0
 
   cursor = get_db().cursor()
+  # source from http://www.evanmiller.org/how-not-to-sort-by-average-rating.html
   executeQuery(cursor,
               '''SELECT ((positive + 1.9208) / (positive + negative)
                         - 1.96 * SQRT((positive * negative) / (positive + negative) + 0.9604) / (positive + negative))
                         / (1 + 3.8416 / (positive + negative)) AS score FROM #PFX#users WHERE id = %s''',
               (contact))

[Wladimir Palant, 2012/10/22 13:32:52]

Please add a link to the source of this formula.

[Andrey Novikov, 2012/10/23 14:15:29]

Done.

-  user = cursor.fetchone()

[Wladimir Palant, 2012/10/22 13:32:52]

You are selecting the score, not the user - please name the variable
appropriately.

[Andrey Novikov, 2012/10/23 14:15:29]

Done.

-  if user == None:
+  score = cursor.fetchone()
+  if score == None:
     return 0
 
-  if user[0] == None: # no score yet
+  if score[0] == None: # no score yet
     return 0.3
   else:
-    return user[0]

[Wladimir Palant, 2012/10/22 13:32:52]

How about returning |4 * user[0]| here? We want this factor to have a lot more
weight than the other factors.

[Andrey Novikov, 2012/10/23 14:15:29]

Done.

+    return 4 * score[0]
 
 def updateUserUsefulness(contact, newusefulness, oldusefulness):
   new = int(newusefulness)
   old = int(oldusefulness)
   if new == old:
     return
   positive = 0
   negative = 0
   if old > 0:
     positive -= 1
@@ skipping 73 matching lines @@
   dbpasswd = get_config().get('reports', 'dbpassword')
   if os.name == 'nt':
     return MySQLdb.connect(user=dbuser, passwd=dbpasswd, db=database, use_unicode=True, charset='utf8', named_pipe=True)
   else:
     return MySQLdb.connect(user=dbuser, passwd=dbpasswd, db=database, use_unicode=True, charset='utf8')
     
 def executeQuery(cursor, query, args=None):
   tablePrefix = get_config().get('reports', 'dbprefix')
   query = re.sub(r'#PFX#', tablePrefix, query)
   cursor.execute(query, args)