Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/reports/static/reports.js

Issue 8625042: Reports - user usefullness (Closed)
Patch Set: Created Oct. 18, 2012, 1:17 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sitescripts/reports/bin/parseNewReports.py ('k') | sitescripts/reports/template/report.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/reports/static/reports.js
===================================================================
--- a/sitescripts/reports/static/reports.js
+++ b/sitescripts/reports/static/reports.js
@@ -29,6 +29,17 @@
return value.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;");
}
+function setRadio(radio, value)
+{
+ for (i = 0; i < radio.length; i++)
+ {
+ if (radio[i].value == value)
+ radio[i].checked = true;
+ else
+ radio[i].checked = false;
+ }
+}
+
function saveSecret(guid, secret)
{
var secrets = localStorage.secrets;
@@ -48,6 +59,9 @@
var statusCell = document.getElementById("statusCell");
if (statusCell)
status = statusCell.textContent;
+
+ var utility = "0";
+ var utilityCell = document.getElementById("utilityCell");
var div = document.createElement("div");
div.className = "updateLink"
@@ -64,10 +78,14 @@
link.onclick = function()
{
var notifyBox = "";
+ var utilityRadios = "";
if (document.getElementById("emailCell"))
+ {
notifyBox = '<span id="notifyField"><input type="checkbox" id="notify" name="notify" value="1" /> <label for="notify">Notify user</label></span>';
-
- div.innerHTML = '<form action="/updateReport" method="POST">' +
+ utilityRadios = '<br />Utility: <input type="radio" name="utility" value="0" checked="checked" /> not established <input type="radio" name="utility" value="1" /> usefull <input type="radio" name="utility" value="-1" /> harmful';
+ }
+
+ div.innerHTML = '<form id="updateForm" action="/updateReport" method="POST">' +
'<input type="hidden" name="secret" value="' + escapeHTML(secret) + '" />' +
'<input type="hidden" name="guid" value="' + escapeHTML(guid) + '" />' +
'<p>' +
@@ -76,7 +94,8 @@
'</p>' +
'<p>' +
'Enter new status:' + notifyBox + '<br />' +
- '<textarea id="statusField" name="status" oninput="updateTemplateButtons();"></textarea>' +
+ '<textarea id="statusField" name="status" oninput="updateTemplateButtons();"></textarea>' +
+ utilityRadios +
'</p>' +
'<div>' +
'<button id="addTemplateButton" type="button" onclick="addTemplate();">Add as template</button>' +
@@ -97,6 +116,12 @@
}, false);
var statusField = document.getElementById("statusField");
statusField.value = status;
+ if (utilityCell)
+ {
+ utility = utilityCell.getAttribute("value");
+ setRadio(document.getElementById("updateForm").elements.utility, utility);
+ }
+
updateTemplates();
statusField.focus();
}
« no previous file with comments | « sitescripts/reports/bin/parseNewReports.py ('k') | sitescripts/reports/template/report.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld