Reports - user usefullness

sitescripts/utils.py

Index: sitescripts/utils.py
===================================================================
--- a/sitescripts/utils.py
+++ b/sitescripts/utils.py
@@ -11,6 +11,22 @@
 
 siteScriptsPath = sitescripts.__path__[0]
 
+class memoize:
+  """
+    Decorator that caches a function with arguments return value.
+  """

[Wladimir Palant, 2012/10/22 13:32:52]

Any reason to introduce a new decorator instead of making cached below consider
arguments properly?

Note that storing values for an unlimited amount of time is generally not
useful, you have no idea how long this process will stay around.

[Andrey Novikov, 2012/10/23 14:15:29]

I thought you were not considering them on purpose.

+  def __init__ (self, f):
+    self.f = f
+    self.mem = {}
+
+  def __call__ (self, *args, **kwargs):
+    if (args, str(kwargs)) in self.mem:

[Wladimir Palant, 2012/10/22 13:32:52]

How about calculating str(kwargs) once at the beginning of the function? Also,
maybe note somewhere that this approach will only work for simple parameter
types.

[Andrey Novikov, 2012/10/23 14:15:29]

Done.

+      return self.mem[args, str(kwargs)]
+    else:
+      tmp = self.f(*args, **kwargs)
+      self.mem[args, str(kwargs)] = tmp
+      return tmp
+
 class cached(object):
   """
     Decorator that caches a function's return value for a given number of seconds.