Fixed: Topic 11234 - toolbar icon not shown in popup windows

lib/windowObserver.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 Cu.import("resource://gre/modules/Services.jsm");
 Cu.import("resource://gre/modules/XPCOMUtils.jsm");
 
 exports.WindowObserver = WindowObserver;
@@ skipping 16 matching lines @@
   let e = Services.ww.getWindowEnumerator();
   while (e.hasMoreElements())
   {
     let window = e.getNext().QueryInterface(Ci.nsIDOMWindow);
     if (when == "start" || window.document.readyState == "complete")
       this._listener.applyToWindow(window);
     else
       this.observe(window, "domwindowopened", null);
   }
 
-  Services.ww.registerNotification(this);
+  Services.obs.addObserver(this, "chrome-document-global-created", false);

[Wladimir Palant, 2012/10/30 17:20:21]

Please use weak references just in case. Meaning that the third parameter here
should be true and the observer needs to expose Ci.nsISupportsWeakReference.

 
   this._shutdownHandler = function()
   {
     let e = Services.ww.getWindowEnumerator();
     while (e.hasMoreElements())
       this._listener.removeFromWindow(e.getNext().QueryInterface(Ci.nsIDOMWindow));
 
-    Services.ww.unregisterNotification(this);
+    Services.obs.removeObserver(this, "chrome-document-global-created");
   }.bind(this);
   onShutdown.add(this._shutdownHandler);
 }
 WindowObserver.prototype =
 {
   _listener: null,
   _when: null,
   _shutdownHandler: null,
+  QueryInterface: XPCOMUtils.generateQI([Ci.nsIObserver]),
 
   shutdown: function()
   {
     if (!this._shutdownHandler)
       return;
 
     onShutdown.remove(this._shutdownHandler);
     this._shutdownHandler();
     this._shutdownHandler = null;
   },
 
   observe: function(subject, topic, data)
   {
-    if (topic == "domwindowopened")
+    if (subject.location.href !== "about:blank")

[Wladimir Palant, 2012/10/30 17:20:21]

Please check |subject instanceof Ci.nsIDOMWindow| first - the parameter you get
is nsISupports, not guaranteed to be a window. instanceof operator has the nice
side-effect of implicitly calling QueryInterface.

[Wladimir Palant, 2012/10/30 18:52:22]

Forgot to mention: there should be a link to Bugzilla here to explain why we
might see about:blank.

     {
       if (this._when == "start")
       {
         this._listener.applyToWindow(window);
         return;
       }
 
       let window = subject.QueryInterface(Ci.nsIDOMWindow);
       let event = (this._when == "ready" ? "DOMContentLoaded" : "load");
       let listener = function()
       {
         window.removeEventListener(event, listener, false);
-        if (this._shutdownHandler)
+        if (this._shutdownHandler && window.document.documentElement.getAttribute("windowtype") == "navigator:browser")

[Wladimir Palant, 2012/10/30 17:20:21]

Is this debug code? Please remove.

           this._listener.applyToWindow(window);
       }.bind(this);
       window.addEventListener(event, listener, false);
     }
   },
 
   QueryInterface: XPCOMUtils.generateQI([Ci.nsISupportsWeakReference, Ci.nsIObserver])
 };