adblockpluschrome: Handle invalid share popup sites

firstRun.js

 var backgroundPage = chrome.extension.getBackgroundPage();
 var require = backgroundPage.require;
 var Prefs = require("prefs").Prefs;
 var Utils = require("utils").Utils;
 
 function openSharePopup(url)
 {
   var iframe = document.getElementById("share-popup");
   var glassPane = document.getElementById("glass-pane");
+  var popupMessageReceived = false;
 
   var popupMessageListener = function(event)
   {
     if (event.origin !== url)
       return;
 
     iframe.width = event.data.width;
     iframe.height = event.data.height;
+    popupMessageReceived = true;
     window.removeEventListener("message", popupMessageListener);
   };
   window.addEventListener("message", popupMessageListener, false);
 
   var popupLoadListener = function()
   {
-    iframe.className = "visible";
+    if (popupMessageReceived)
+    {
+      iframe.className = "visible";
 
-    var popupCloseListener = function()
-    {
-      iframe.className = glassPane.className = "";
-      document.removeEventListener("click", popupCloseListener);
-    };
-    document.addEventListener("click", popupCloseListener, false);
+      var popupCloseListener = function()
+      {
+        iframe.className = glassPane.className = "";
+        document.removeEventListener("click", popupCloseListener);
+      };
+      document.addEventListener("click", popupCloseListener, false);
+    }
+    else
+      glassPane.className = "";

[Wladimir Palant, 2012/10/25 15:54:15]

Also remove message listener here?

[Felix Dahlke, 2012/10/25 15:57:11]

Done.

+
     iframe.removeEventListener("load", popupLoadListener);
   };
   iframe.addEventListener("load", popupLoadListener, false);
 
   iframe.src = url;
   glassPane.className = "visible";
 }
 
 function initSocialLinks(variant)
 {
@@ skipping 61 matching lines @@
     }
   }
 }
 
 function getDocLink(page, anchor)
 {
   return Prefs.documentation_link
               .replace(/%LINK%/g, page)
               .replace(/%LANG%/g, Utils.appLocale) + (anchor ? "#" + anchor : "");
 }