adblockpluschrome: Handle invalid share popup sites

firstRun.js

 var backgroundPage = chrome.extension.getBackgroundPage();
 var require = backgroundPage.require;
 var Prefs = require("prefs").Prefs;
 var Utils = require("utils").Utils;
 
 function openSharePopup(url)
 {
   var iframe = document.getElementById("share-popup");
   var glassPane = document.getElementById("glass-pane");
   var popupMessageReceived = false;
-  var popupVisible = false;
 
   var popupMessageListener = function(event)
   {
     if (event.origin !== url)
       return;
 
     iframe.width = event.data.width;
     iframe.height = event.data.height;
     popupMessageReceived = true;
     window.removeEventListener("message", popupMessageListener);
   };
   window.addEventListener("message", popupMessageListener, false);
 
   var popupLoadListener = function()
   {
     if (popupMessageReceived)
     {
       iframe.className = "visible";
-      popupVisible = true;
 
       var popupCloseListener = function()
       {
         iframe.className = glassPane.className = "";
         document.removeEventListener("click", popupCloseListener);
       };
       document.addEventListener("click", popupCloseListener, false);
     }
+    else
+      glassPane.className = "";

[Wladimir Palant, 2012/10/25 15:54:15]

Also remove message listener here?

[Felix Dahlke, 2012/10/25 15:57:11]

Done.

+
     iframe.removeEventListener("load", popupLoadListener);
   };
   iframe.addEventListener("load", popupLoadListener, false);
 
   iframe.src = url;
   glassPane.className = "visible";
-
-  setTimeout(function()
-  {
-    if (!popupVisible)
-      glassPane.className = "";
-  }, 2000);

[Wladimir Palant, 2012/10/25 15:32:51]

This timeout should be 20 seconds at least, otherwise we exclude people in China
and such. But on a second thought - do we even need that timeout? There will
always be a "load" event, even if it is an error page. If we don't receive the
message then we just close the pop-up (call popupCloseListener without
registering it) and we are done with it.

[Felix Dahlke, 2012/10/25 15:39:27]

You're right, the load event will even arrive eventually when the user is
offline.

 }
 
 function initSocialLinks(variant)
 {
   var networks = ["twitter", "facebook"];
   networks.forEach(function(network)
   {
     var links = document.getElementsByClassName("share-" + network);
     for (var i = 0; i < links.length; i++)
     {
@@ skipping 55 matching lines @@
     }
   }
 }
 
 function getDocLink(page, anchor)
 {
   return Prefs.documentation_link
               .replace(/%LINK%/g, page)
               .replace(/%LANG%/g, Utils.appLocale) + (anchor ? "#" + anchor : "");
 }