Detect and handle the case of our own typo correction extension being installed in parallel

lib/typoBootstrap.js

 /*
- * This Source Code is subject to the terms of the Mozilla Public License
- * version 2.0 (the "License"). You can obtain a copy of the License at
- * http://mozilla.org/MPL/2.0/.
+ * This file is part of the Adblock Plus,
+ * Copyright (C) 2006-2012 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /**
  * @fileOverview Adds typo correction feature
  */
 
 Cu.import("resource://gre/modules/AddonManager.jsm");
 
-let {TimeLine} = require("timeline");
 let {Prefs} = require("prefs");
-TimeLine.log("Done loading preferences");
+let urlfixerID = "{0fa2149e-bb2c-4ac2-a8d3-479599819475}";
+let addonListener = null;
 
-Cu.reportError("init");
-let urlfixerID = "{0fa2149e-bb2c-4ac2-a8d3-479599819475}";
-let isTypoCorrectionEnabled = false;
-
-function enableTypoCorrection()
+function init()
 {
-  Cu.reportError("enable");
-  if (isTypoCorrectionEnabled)
-    return;
-  
-  require("typoFixer").attachWindowObserver();
-  isTypoCorrectionEnabled = true;
-}
-
-function disableTypoCorrection()
-{
-  Cu.reportError("disable");
-  if (!isTypoCorrectionEnabled)
-    return;
-  
-  require("typoFixer").detachWindowObserver();
-  isTypoCorrectionEnabled = false;
-}
-
-/*

[Wladimir Palant, 2012/11/19 13:49:45]

Debug code?

-function checkAddonStatusAndEnable()
-{
-  Cu.reportError("check addon status and enable");
-  AddonManager.getAddonByID(urlfixerID, function(addon)
+  if (!Prefs.correctTyposAsked || (Prefs.correctTyposAsked && Prefs.correctTypos))
   {
-    checkAndEnable(addon && !addon.userDisabled);
-  });
-}
-
-function checkAndEnable(isInstalledAndEnabled)
-{
-  Cu.reportError("check and enable");
-  //Cu.reportError(isInstalledAndEnabled);
-  Cu.reportError(Prefs.correctTyposAsked);
-  Cu.reportError(Prefs.correctTypos);
-  Cu.reportError(isTypoCorrectionEnabled);
-  if (isInstalledAndEnabled)
-  {
-    disableTypoCorrection();
+    AddonManager.getAddonByID(urlfixerID, function(addon)
+    {
+      startTypoCorrection(addon && addon.isActive);
+    });
   }
   else
   {
-    if (!Prefs.correctTyposAsked || (Prefs.correctTyposAsked && Prefs.correctTypos))
+    let onPrefChange = function(name)
     {
-      Cu.reportError("feature enabled");
-      enableTypoCorrection();
-    }
-    else if (!isTypoCorrectionEnabled)
-    {
-      Cu.reportError("feature disabled");
-      function onPrefChange(name)
+      if (name == "correctTypos" && Prefs[name])
       {
-        if (name == "correctTypos")
-        {
-          checkAddonStatusAndEnable();
-          Prefs.removeListener(onPrefChange);
-        }
-      }
-      
-      Prefs.addListener(onPrefChange);
-    }
-  }
-}
-
-let addonListener = {
-  onEnabling: function(addon, needsRestart)
-  {
-    if (addon.id == urlfixerID)
-      checkAndEnable(true);
-  },
-  onDisabled: function(addon)
-  {
-    if (addon.id == urlfixerID)
-      checkAndEnable(false);
-  },
-  onInstalling: function(addon, needsRestart)
-  {
-    if (addon.id == urlfixerID)
-      checkAndEnable(true);
-  },
-  onUninstalled: function(addon)
-  {
-    if (addon.id == urlfixerID)
-      checkAndEnable(false);
-  }
-}
-AddonManager.addAddonListener(addonListener);
-
-checkAddonStatusAndEnable();
-*/
-
-let addonListener = null;
-function checkAndEnable(isInstalledAndEnabled)
-{
-  if (!Prefs.correctTyposAsked || (Prefs.correctTyposAsked && Prefs.correctTypos))
-  {
-    Cu.reportError("feature enabled");
-    Cu.reportError("check addon status and enable");
-    
-    if (typeof isInstalledAndEnabled == "undefined")
-    {
-      // must not be executed for addonListener because it needs to run synchronously
-      AddonManager.getAddonByID(urlfixerID, function(addon)
-      {
-        if (addon && !addon.userDisabled)
-          disableTypoCorrection();
-        else
-          enableTypoCorrection();
-      });
-    }
-    else
-    {
-      if (isInstalledAndEnabled)
-        disableTypoCorrection();
-      else
-        enableTypoCorrection();
-    }
-    
-    if (!addonListener)
-    {
-      addonListener = {
-        onEnabling: function(addon, needsRestart)
-        {
-          if (addon.id == urlfixerID)
-            checkAndEnable(true);
-        },
-        onDisabled: function(addon)
-        {
-          if (addon.id == urlfixerID)
-            checkAndEnable(false);
-        },
-        onInstalling: function(addon, needsRestart)
-        {
-          if (addon.id == urlfixerID)
-            checkAndEnable(true);
-        },
-        onUninstalled: function(addon)
-        {
-          if (addon.id == urlfixerID)
-            checkAndEnable(false);
-        }
-      }
-      AddonManager.addAddonListener(addonListener);
-    }
-  }
-  else if (!isTypoCorrectionEnabled)
-  {
-    Cu.reportError("feature disabled");
-    function onPrefChange(name)
-    {
-      if (name == "correctTypos")
-      {
-        checkAndEnable();
+        init();
         Prefs.removeListener(onPrefChange);
       }
     }
     
     Prefs.addListener(onPrefChange);
   }
 }
 
-function checkAddonStatusAndEnable(isInstalledAndEnabled)
+function startTypoCorrection(isInstalledAndEnabled)
 {
   if (isInstalledAndEnabled)
-    disableTypoCorrection();
+    require("typoFixer").detachWindowObserver();
   else
-    enableTypoCorrection();
+    require("typoFixer").attachWindowObserver();
+  
+  if (!addonListener)
+  {
+    addonListener = {
+      onEnabling: function(addon, needsRestart)
+      {
+        if (addon.id == urlfixerID)
+          startTypoCorrection(true);
+      },
+      onDisabled: function(addon)
+      {
+        if (addon.id == urlfixerID)
+          startTypoCorrection(false);
+      },
+      onInstalling: function(addon, needsRestart)
+      {
+        if (addon.id == urlfixerID)
+          startTypoCorrection(true);
+      },
+      onUninstalled: function(addon)
+      {
+        if (addon.id == urlfixerID)
+          startTypoCorrection(false);
+      }
+    }
+    
+    AddonManager.addAddonListener(addonListener);
+    onShutdown.add(function() AddonManager.removeAddonListener(addonListener));
+  }
 }
 
-checkAndEnable();
+init();