Reports - user profile

sitescripts/reports/web/showUser.py

 # coding: utf-8
 
-# This Source Code is subject to the terms of the Mozilla Public License
-# version 2.0 (the "License"). You can obtain a copy of the License at
-# http://mozilla.org/MPL/2.0/.
+# This file is part of the Adblock Plus web scripts,
+# Copyright (C) 2006-2012 Eyeo GmbH
+#
+# Adblock Plus is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by the Free Software Foundation.
+#
+# Adblock Plus is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 import re
 from urlparse import parse_qs
-from sitescripts.reports.utils import getUser, getUserUsefulnessScore
+from sitescripts.reports.utils import getUser, getReportsForUser
 from sitescripts.utils import get_config, get_template, setupStderr
 from sitescripts.web import url_handler
 
 @url_handler('/showUser')
 def handleRequest(environ, start_response):
   setupStderr(environ['wsgi.errors'])
 
   params = parse_qs(environ.get('QUERY_STRING', ''))
 
   id = params.get('id', [''])[0].lower()
   if not re.match(r'^[\da-f]{32}$', id):
     return showError('Invalid or missing ID', start_response)
-  email = params.get('email', [''])[0].lower()

[Wladimir Palant, 2012/11/07 08:38:15]

Left-over code? Please remove.

[Andrey Novikov, 2012/11/07 09:38:48]

Done.

 
   user = getUser(id)
   if user == None:
     return showError('User not found', start_response)
 
-  user['score'] = getUserUsefulnessScore(id)

[Wladimir Palant, 2012/11/07 08:38:15]

You know that I dislike doing two database queries where one would be
sufficient...

How about changing getUserUsefulnessScore() to call getUser() and then a new
function calculateScore(positive, negative)? calculateScore() would then perform
the calculation you are currently doing in MySQL - and you could use it here as
well.

[Andrey Novikov, 2012/11/07 09:38:48]

Done.

+  user['reportlist'] = getReportsForUser(id)
 
   template = get_template(get_config().get('reports', 'showUserTemplate'))
   start_response('200 OK', [('Content-Type', 'application/xhtml+xml; charset=utf-8')])
   return [template.render(user).encode('utf-8')]
   
 def showError(message, start_response):
   template = get_template(get_config().get('reports', 'errorTemplate'))
   start_response('400 Processing Error', [('Content-Type', 'application/xhtml+xml; charset=utf-8')])
   return [template.render({'message': message}).encode('utf-8')]