Encourage user to set email in issue reporter

chrome/content/ui/sendReport.js

 /*
  * This file is part of the Adblock Plus,
  * Copyright (C) 2006-2012 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 1305 matching lines @@
   textElement.abpInitialized = true;
 }
 
 function updateTypeWarningOverride()
 {
   document.documentElement.canAdvance = E("typeWarningOverride").checked;
 }
 
 function initScreenshotPage()
 {
   document.documentElement.canAdvance = true;

[Wladimir Palant, 2012/11/22 14:16:29]

I am mostly sure that canAdvance = true is set automatically after switching
pages. Is this necessary?

[Andrey Novikov, 2012/11/22 14:44:15]

It stays disabled in my case when I press Back on Comments page.

 
   E("progressBar").activeItem = E("screenshotHeader");
 }
 
 function initCommentPage()
 {
-  document.documentElement.canAdvance = false;
-
   E("progressBar").activeItem = E("commentPageHeader");
 
   updateEmail();

[Wladimir Palant, 2012/11/22 14:16:29]

This will already set the canAdvance property, I don't see much point doing it
in this function as well.

[Andrey Novikov, 2012/11/22 14:44:15]

Done.

   
   screenshotDataSource.exportData();
   updateDataField();
 }
 
 function showDataField()
 {
   E('dataDeck').selectedIndex = 1;
   updateDataField();
   E('data').focus();
@@ skipping 31 matching lines @@
   let value = E("comment").value;
   appendElement(reportData.documentElement, "comment", null, value.substr(0, 1000));
   E("commentLengthWarning").setAttribute("visible", value.length > 1000);
   updateDataField();
 }
 
 function updateEmail()
 {
   removeReportElement("email");
   
+  let anonymous = E("anonymousCheckbox").checked;
+  
   let value = E("email").value;
-  E("email").setAttribute("value", value); // https://bugzilla.mozilla.org/show_bug.cgi?id=111486

[Wladimir Palant, 2012/11/22 14:16:29]

Please add a proper comment - the bug link is additional info, not an
explanation.

[Andrey Novikov, 2012/11/22 14:44:15]

Done.

-  appendElement(reportData.documentElement, "email", null, value);
-  updateDataField();
-  
-  document.documentElement.canAdvance = /\S/.test(value);
-}
-
-function updateAnonymity(anonymous)
-{
-  if (anonymous)
-  {
-    E("email").value = "";
-    updateEmail();
-  }
+
+  // required for persist to work on textbox, see: https://bugzilla.mozilla.org/show_bug.cgi?id=111486
+  E("email").setAttribute("value", value);
+
   E("email").disabled = anonymous;
   E("emailLabel").disabled = anonymous;

[Wladimir Palant, 2012/11/22 14:16:29]

I don't think we ever disable labels.

[Andrey Novikov, 2012/11/22 14:44:15]

It looks much more user friendly in UI, have a try. But if you wish I will
remove it.

   E("anonymityWarning").setAttribute("visible", anonymous);
 
-  document.documentElement.canAdvance = anonymous;
+  if (!anonymous)
+    appendElement(reportData.documentElement, "email", null, value);
+
+  updateDataField();
+
+  document.documentElement.canAdvance = anonymous || /\S/.test(value);
 }

[Wladimir Palant, 2012/11/22 14:16:29]

The interaction of these two functions is pretty complex, depending on the order
in which they are called. For example: use enters an email address, checks
"anonymous" checkbox then. Email address will still be sent with your code.
Please make updateEmail() consider the anonymous checkbox instead, to make the
logic obvious - same function should be called regardless of whether the
textfield or the checkbox was updated.

[Andrey Novikov, 2012/11/22 14:44:15]

It sends empty value in that case. Redesigned it.

 
 function updateExtensions(attach)
 {
   extensionsDataSource.exportData(attach);
   updateDataField();
 }
 
 function initSendPage()
 {
   E("progressBar").activeItem = E("sendPageHeader");
@@ skipping 144 matching lines @@
 
 function censorURL(url)
 {
   return url.replace(/([?;&\/#][^?;&\/#]+?=)[^?;&\/#]+/g, "$1*");
 }
 
 function encodeHTML(str)
 {
   return str.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;");
 }