First run page

chrome/content/ui/firstRun.js

 /*
  * This file is part of the Adblock Plus,
  * Copyright (C) 2006-2012 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+(function()
+{
+  var contentHeight = 0;
+  var left;
+  var right;

[Wladimir Palant, 2013/05/07 15:01:12]

The variables left and right seem to be unused.

+  var shade;
+  var scrollTimer;
+
+  function onDomReady()
+  {
+    shade = document.getElementById("shade");
+
+    shade.addEventListener("mouseover", scrollPage, false);
+    shade.addEventListener("mouseout", stopScroll, false);
+
+    window.addEventListener('resize', onWindowResize, false);
+    document.addEventListener('scroll', onScroll, false);
+
+    onWindowResize();
+  }
+
+  function onScroll()
+  {
+    var currentHeight = document.documentElement.scrollTop + document.body.scrollTop + document.documentElement.clientHeight;
+    shade.style.opacity = (contentHeight == currentHeight) ? "0.0" : "0.5";
+  }
+
+  function onWindowResize()
+  {
+    contentHeight = document.documentElement.scrollHeight;
+    shade.style.opacity = (contentHeight > document.documentElement.clientHeight) ? "0.5" : "0.0";

[Wladimir Palant, 2013/05/07 15:01:12]

Why do we have different logic here and in onScroll? This function should simply
call onScroll. No point caching contentHeight, onScroll can simply look it up
every time.

+  }
+
+  function scrollPage()
+  {
+     window.scrollBy(0, 5);
+     scrollTimer = setTimeout(scrollPage, 20);

[Wladimir Palant, 2013/05/07 15:01:12]

What if mouseover event fires twice for some reason (e.g. because you catch the
event from a child element)? Cleaner solution:

function scrollPage()
{
  if (scrollTimer)
    stopScroll();

  scrollTimer = setInterval(function()
  {
    window.scrollBy(0, 5);
  }, 20);
}

function stopScroll()
{
  clearTimeout(scrollTimer);
  scrollTimer = null;
}

+  }
+
+  function stopScroll()
+  {
+     clearTimeout(scrollTimer);
+  }
+
+  function scrollContent(direction)

[Wladimir Palant, 2013/05/07 15:01:12]

This function seems to be unused code.

+  {
+    cur -= direction;
+    if (cur < 0) cur = 0;
+    if (cur > cols) cur = cols;
+
+    left.style.visibility="hidden";
+    right.style.visibility="hidden";
+    
+    if (cur > 0 && cur <= cols)
+      left.style.visibility="visible";
+    if (cur < cols && cols > 0)
+      right.style.visibility="visible";
+
+    innerBase.style.left = (cur * -width) + "px";
+  }
+
+  document.addEventListener("DOMContentLoaded", onDomReady, false);
+})();
+
 function init()
 {
+  E("currentVersion").textContent = Prefs.currentVersion;
+  
   generateLinkText(E("changeDescription"));
 
   for each (let subscription in FilterStorage.subscriptions)
   {
     if (subscription instanceof DownloadableSubscription && subscription.url != Prefs.subscriptions_exceptionsurl && !subscription.disabled)
     {
       E("listName").textContent = subscription.title;
 
       let link = E("listHomepage");
       link.setAttribute("href", subscription.homepage);
@@ skipping 50 matching lines @@
           Utils.runAsync(showOptions);
         else
           topWnd.ExtensionsView.showOptions(Utils.addonID);
       }
       showOptions();
     }
   }
   else
     UI.openFiltersDialog();
 }
+