Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/firstRun.xhtml

Issue 9078049: First run page (Closed)
Patch Set: Created Dec. 28, 2012, 11:06 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/content/ui/firstRun.xhtml
===================================================================
--- a/chrome/content/ui/firstRun.xhtml
+++ b/chrome/content/ui/firstRun.xhtml
@@ -21,32 +21,88 @@
<head>
<title>&dialog.title;</title>
<script type="application/x-javascript;version=1.7" src="utils.js"/>
+ <script type="application/x-javascript;version=1.7" src="typoSettings.js"/>
<script type="application/x-javascript;version=1.7" src="firstRun.js"/>
<link type="text/css" href="chrome://adblockplus/skin/firstRun.css" rel="stylesheet"/>
</head>
- <body onload="init()">
- <p>&confirmation;</p>
+ <body>
+ <div id="shade" class="arrow"></div>
+ <div id="content">
+ <header>
+ <h1>Adblock Plus has been installed</h1>
+ </header>
- <div class="sectionContainer">
- <p class="sectionTitle">&advancedSection;</p>
+ <p>
+ Adblock Plus will always block annoying ads. Still, we want to encourage
+ websites using plain and unobtrusive advertising. That's why we have established
+ <a href="#" onclick="UI.loadDocLink('acceptable_ads', 'criteria'); return false;">strict guidelines</a>
Wladimir Palant 2013/05/07 15:01:12 In fact, that's something we've done wrong in Chro
+ to identify acceptable ads, and allow these out of the box. You can always
+ <a href="#" onclick="openFilters(); return false;">disable</a> this if you want to block all ads.
+ </p>
- <p>&listSelection1;</p>
+ <h2>Adblock Plus can do more then block ads:</h2>
Wladimir Palant 2013/05/07 15:01:12 s/then/than/
- <p id="listNameContainer" hidden="true">
- <div id="listName"/>
- <a id="listHomepage" onclick="UI.loadInBrowser(this.getAttribute('href')); return false;">&visitHomepage.label;</a>
- </p>
- <p id="listNone">&noList;</p>
-
- <p id="acceptableAds" hidden="true">
- &acceptableAds2;
- <a href="#" onclick="UI.loadInBrowser(Prefs.subscriptions_exceptionsurl); return false;">&viewList.label;</a>
- <a href="#" onclick="UI.loadDocLink('acceptable_ads'); return false;">&readMore.label;</a>
- </p>
+ <div id="features">
+ <div class="feature">
Wladimir Palant 2013/05/07 15:01:12 Wrong indentation here.
+ <img src="chrome://adblockplus/skin/features/typo.png" alt="Typo Correction"/>
Wladimir Palant 2013/05/07 15:01:12 I would suggest going with alt="" here - the alt t
+ <h1>Typo Correction</h1>
+ <p>
+ Adblock Plus can automatically correct typos in the address bar
+ to protect you from visiting malicious websites when misspelling an
+ internet address.
+ </p>
+ <button onclick="TypoActions.setEnabled(true); this.setAttribute('hidden', 'true'); return false;">Activate</button>
Wladimir Palant 2013/05/07 15:01:12 We shouldn't be using inline JavaScript if we want
+ </div>
+ <div class="feature">
+ <img src="chrome://adblockplus/skin/features/malware.png" alt="Malware Blocking"/>
+ <h1>Malware Blocking</h1>
+ <p>
+ Adblock Plus can block domains that are known to be infected by malware
+ to make browsing the internet more secure.
+ </p>
+ <button>Activate</button>
Wladimir Palant 2013/05/07 15:01:12 This is obviously a TODO.
+ </div>
+ <div class="feature">
+ <img src="chrome://adblockplus/skin/features/social.png" alt="Remove Social Media Buttons"/>
+ <h1>Remove Social Media Buttons</h1>
+ <p>
+ Social media integration such as the Facebook Like button can be used
+ to track your browsing habits. Adblock Plus can remove all social media
+ buttons.
+ </p>
+ <button>Activate</button>
Wladimir Palant 2013/05/07 15:01:12 This is obviously a TODO.
+ </div>
+ <div class="feature">
+ <img src="chrome://adblockplus/skin/features/tracking.png" alt="Disable Tracking"/>
+ <h1>Disable Tracking</h1>
+ <p>
+ Enter nice description here.
+ </p>
+ <button>Activate</button>
Wladimir Palant 2013/05/07 15:01:12 This is obviously a TODO.
+ </div>
</div>
- <p id="changeDescription" _textTemplate="&listSelection2;">
- <a href="#" onclick="openFilters(); return false;"/>
- </p>
+ <footer id="social">
+ <ul>
+ <li>
+ <a href="https://www.facebook.com/adblockplus">
+ <img src="chrome://adblockplus/skin/social/facebook.png" width="82" height="82" alt="Facebook logo"/>
Wladimir Palant 2013/05/07 15:01:12 Alt text should be "Share on Facebook" here - othe
+ </a>
+ </li>
+ <li>
+ <a href="https://twitter.com/adblockplus">
+ <img src="chrome://adblockplus/skin/social/twitter.png" width="82" height="82" alt="Twitter logo"/>
+ </a>
+ </li>
+ <li>
+ <a href="https://plus.google.com/110020691898167279887">
+ <img src="chrome://adblockplus/skin/social/gplus.png" width="82" height="82" alt="Google+ logo"/>
+ </a>
+ </li>
+ </ul>
+ <!-- This is a hack, header should go before content, but I do not know how to make address it with CSS then. -->
+ <h1>Think Adblock Plus is worth sharing?</h1>
+ </footer>
+ </div>
</body>
</html>

Powered by Google App Engine
This is Rietveld