modules/adblockplusorg/files/adblockplus.org - Issue 9103016: Fix url-based rewrites

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: modules/adblockplusorg/files/adblockplus.org

Issue 9103016: Fix url-based rewrites (Closed)

Patch Set: Made browser rewriting work for /en/ etc. Created Jan. 9, 2013, 10:43 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: modules/adblockplusorg/files/adblockplus.org

===================================================================

--- a/modules/adblockplusorg/files/adblockplus.org

+++ b/modules/adblockplusorg/files/adblockplus.org

@@ -29,7 +29,7 @@

if ($arg_a ~ ^(view|show)?$) {

rewrite ^/(index\.html)?$ /$preferredLang/$browser redirect;

- rewrite ^/(\w\w(_\w\w)?)$ /$1/$browser redirect;

+ rewrite ^/(\w\w(_\w\w)?)/?$ /$1/$browser redirect;

}

rewrite ^/(\w\w(_\w\w)?)/installation$ /$1/ permanent;

@@ -43,7 +43,7 @@

}

set $static_uri $uri;

- if ($uri ~ ^/(\w\w(_\w\w)?)/(firefox|chrome|opera|android)) {

+ if ($uri ~ ^/(\w\w(_\w\w)?)/(firefox|chrome|opera|android)/?$) {

set $static_uri "/$1/";

set $browser $3;

}

@@ -59,7 +59,7 @@

rewrite ^ /static$static_uri?browser=$browser last;

}

- rewrite ^/(\w\w(_\w\w)?)/(firefox|chrome|opera|android) /index.php?p=$1&browser=$3 last;

+ rewrite ^/(\w\w(_\w\w)?)/(firefox|chrome|opera|android)/?$ /index.php?p=$1&browser=$3 last;

rewrite ^/(.*) /index.php?p=$1 last;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »