Bug 819131 work-around, use user data instead of weak maps

lib/requestNotifier.js

 /*
  * This file is part of the Adblock Plus,
  * Copyright (C) 2006-2012 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 13 matching lines @@
 let {Utils} = require("utils");
 let {BlockingFilter, WhitelistFilter, ElemHideBase, ElemHideFilter, ElemHideException} = require("filterClasses");
 
 let nodeData = new WeakMap();
 let windowStats = new WeakMap();
 let windowSelection = new WeakMap();
 
 let setEntry, hasEntry, getEntry;
 if (false)
 {
-  // Bug 673468 and bug 819131 are fixed, we can use weak maps

[Felix Dahlke, 2013/01/23 14:15:28]

Shouldn't this be: "Bug 673468 is fixed, but 819131 is not, so we cannot use
weak maps"?

+  // This branch can be enabled again once both bug 673468 and bug 819131 are
+  // fixed and we can use weak maps
   setEntry = function(map, key, value) map.set(key, value);
   hasEntry = function(map, key) map.has(key);
   getEntry = function(map, key) map.get(key);
 }
 else
 {
   // Fall back to user data
   let dataSeed = Math.random();
   let nodeDataProp = "abpNodeData" + dataSeed;
   let windowStatsProp = "abpWindowStats" + dataSeed;
   let windowSelectionProp = "abpWindowSelection" + dataSeed;
-  function getProp(map)
+  let getProp = function(map)

[Wladimir Palant, 2013/01/23 14:48:33]

Please ignore this change, it's from a different commit and subject to a
separate review.

   {
     switch (map)
     {
       case nodeData:
         return nodeDataProp;
       case windowStats:
         return windowStatsProp;
       case windowSelection:
         return windowSelectionProp;
       default:
         return null;
     }
-  }
+  };
 
   setEntry = function(map, key, value) key.setUserData(getProp(map), value, null);
   hasEntry = function(map, key) key.getUserData(getProp(map));
   getEntry = function(map, key) key.getUserData(getProp(map)) || undefined;
 }
 
 /**
  * List of notifiers in use - these notifiers need to receive notifications on
  * new requests.
  * @type RequestNotifier[]
@@ skipping 304 matching lines @@
     if (typeof existingData == "undefined")
     {
       existingData = {};
       setEntry(nodeData, node, existingData);
     }
 
     // Add this request to the node data
     existingData[this.type + " " + this.location] = this;
   }
 };