Get rid of nested functions declarations that are not on top level (causes strict mode warnings)

lib/appSupport.js

 /*
  * This file is part of the Adblock Plus,
  * Copyright (C) 2006-2012 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 466 matching lines @@
 
       let parent = window.document.getElementById("messagepanebox");
       if (!parent || !(parent.compareDocumentPosition(browser) & Ci.nsIDOMNode.DOCUMENT_POSITION_CONTAINED_BY))
         parent = browser.parentNode;
 
       _addBottomBar(window, parent, element);
     };
 
     exports.removeBottomBar = _removeBottomBar;
 
-    function BrowserChangeListener(window, callback)
+    let BrowserChangeListener = function(window, callback)
     {
       this.window = window;
       this.callback = callback;
       this.onSelect = this.onSelect.bind(this);
       this.attach();
     };
     BrowserChangeListener.prototype = {
       window: null,
       callback: null,
       currentBrowser: null,
@@ skipping 186 matching lines @@
   }
 
   case "fennec2":
   {
     exports.isKnownWindow = function fmn_isKnownWindow(/**Window*/ window) window.document.documentElement.id == "main-window";
 
     exports.getBrowser = function fmn_getBrowser(window) window.BrowserApp.selectedBrowser;
 
     exports.addTab = function fmn_addTab(window, url, event) window.BrowserApp.addTab(url, {selected: true});
 
-    function BrowserChangeListener(window, callback)
+    let BrowserChangeListener = function(window, callback)
     {
       this.window = window;
       this.callback = callback;
       this.onSelect = this.onSelect.bind(this);
       this.attach();
     };
     BrowserChangeListener.prototype = {
       window: null,
       callback: null,
       currentBrowser: null,
@@ skipping 123 matching lines @@
 
       clickListeners.delete(window);
     };
 
     let {Filter} = require("filterClasses");
     let {Prefs} = require("prefs");
     let {Policy} = require("contentPolicy");
     let {UI} = require("ui");
     let {Utils} = require("utils");
 
-    function toggleWhitelist(window)
+    let toggleWhitelist = function(window)
     {
       if (!Prefs.enabled)
       {
         Prefs.enabled = true;
         return;
       }
 
       let location = exports.getCurrentLocation(window);
       let host = null;
       if (location instanceof Ci.nsIURL && Policy.isBlockableScheme(location))
       {
         try
         {
           host = location.host.replace(/^www\./, "");
         } catch (e) {}
       }
 
       if (!host)
         return;
 
       if (Policy.isWhitelisted(location.spec))
         UI.removeWhitelist(window);
       else
         UI.toggleFilter(Filter.fromText("@@||" + host + "^$document"));
-    }
+    };
 
     let menuItem = null;
     onShutdown.add(function()
     {
       let window = null;
       for (window in UI.applicationWindows)
         break;
 
       if (window && menuItem)
         window.NativeWindow.menu.remove(menuItem);
@@ skipping 42 matching lines @@
     {
       let dialogTitle = this.overlay.attributes.subscriptionDialogTitle;
       let dialogMessage = this.overlay.attributes.subscriptionDialogMessage.replace(/\?1\?/, title).replace(/\?2\?/, url);
       if (Utils.confirm(window, dialogMessage, dialogTitle))
         this.setSubscription(url, title);
     };
 
     break;
   }
 }