Get rid of nested functions declarations that are not on top level (causes strict mode warnings)

lib/synchronizer.js

 /*
  * This file is part of the Adblock Plus,
  * Copyright (C) 2006-2012 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 43 matching lines @@
  * @class
  */
 let Synchronizer = exports.Synchronizer =
 {
   /**
    * Called on module startup.
    */
   init: function()
   {
     TimeLine.enter("Entered Synchronizer.init()");
-  
+
     let callback = function()
     {
       timer.delay = CHECK_INTERVAL * MILLISECONDS_IN_SECOND;
       checkSubscriptions();
     };
-  
+
     timer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer);
     timer.initWithCallback(callback, INITIAL_DELAY * MILLISECONDS_IN_SECOND, Ci.nsITimer.TYPE_REPEATING_SLACK);
     onShutdown.add(function()
     {
       timer.cancel();
     });
-  
+
     TimeLine.leave("Synchronizer.init() done");
   },
 
   /**
    * Checks whether a subscription is currently being downloaded.
    * @param {String} url  URL of the subscription
    * @return {Boolean}
    */
   isExecuting: function(url)
   {
@@ skipping 73 matching lines @@
     else
     {
       // Ignore modification date if we are downloading from a different location
       forceDownload = true;
     }
 
     let {addonVersion} = require("info");
     loadFrom = loadFrom.replace(/%VERSION%/, "ABP" + addonVersion);
 
     let request = null;
-    function errorCallback(error)
+    let errorCallback = function(error)
     {
       let channelStatus = -1;
       try
       {
         channelStatus = request.channel.status;
       } catch (e) {}
       let responseStatus = "";
       try
       {
         responseStatus = request.channel.QueryInterface(Ci.nsIHttpChannel).responseStatus;
       } catch (e) {}
       setError(subscription, error, channelStatus, responseStatus, loadFrom, isBaseLocation, manual);
-    }
+    };
 
     try
     {
       request = Cc["@mozilla.org/xmlextras/xmlhttprequest;1"].createInstance(Ci.nsIXMLHttpRequest);
       request.mozBackgroundRequest = true;
       request.open("GET", loadFrom);
     }
     catch (e)
     {
       errorCallback("synchronize_invalid_url");
@@ skipping 18 matching lines @@
 
         getInterface: function(iid)
         {
           if (iid.equals(Ci.nsIChannelEventSink))
           {
             try {
               oldEventSink = oldNotifications.QueryInterface(iid);
             } catch(e) {}
             return this;
           }
-    
+
           if (oldNotifications)
             return oldNotifications.QueryInterface(iid);
           else
             throw Cr.NS_ERROR_NO_INTERFACE;
         },
 
         asyncOnChannelRedirect: function(oldChannel, newChannel, flags, callback)
         {
           if (isBaseLocation && !hadTemporaryRedirect && oldChannel instanceof Ci.nsIHttpChannel)
           {
@@ skipping 371 matching lines @@
           newSubscription.disabled = subscription.disabled;
           FilterStorage.removeSubscription(subscription);
           FilterStorage.addSubscription(newSubscription);
           Synchronizer.execute(newSubscription);
         }
       }, false);
       request.send(null);
     }
   }
 }