Add logrotate cronjob to all servers, don`t run logrotate unnecessarily on provisioning and use con…

modules/nginx/manifests/init.pp

 class nginx (
     $worker_processes = $nginx::params::worker_processes,
     $worker_connections = $nginx::params::worker_connections
   ) inherits nginx::params {
 
   package {'nginx':
     ensure => present
   }
 
   File {
@@ skipping 27 matching lines @@
     if $enabled == true {
       file {"/etc/nginx/sites-enabled/${file}":
         ensure  => link,
         require => File["/etc/nginx/sites-available/${file}"],
         target => "/etc/nginx/sites-available/${file}",
         notify => Service['nginx']
       }
     }
   }
 
-#  file {'/etc/logrotate.d/nginx':
-#    source => 'nginx/logrotate',
-#    require => File['/etc/nginx/nginx.conf']
-#  }
+  file {'/etc/logrotate.d/nginx':
+    source => 'puppet:///modules/nginx/logrotate',
+    require => File['/etc/nginx/nginx.conf']

[Felix Dahlke, 2013/02/07 15:38:41]

Why require the file here? Either the package, if we overwrite a default file
created by nginx, or nothing.

+  }
 
   service {'nginx':
     ensure => running,
     enable => true,
     restart => '/etc/init.d/nginx reload',
     hasstatus => true,
     require => File['/etc/nginx/nginx.conf']
   }
 }