modules/logrotate/manifests/init.pp - Issue 9351014: Add logrotate cronjob to all servers, don`t run logrotate unnecessarily on provisioning and use con…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: modules/logrotate/manifests/init.pp

Issue 9351014: Add logrotate cronjob to all servers, don`t run logrotate unnecessarily on provisioning and use con… (Closed)

Left Patch Set: Created Feb. 7, 2013, 3:06 p.m.

Right Patch Set: Created Feb. 8, 2013, 8:19 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 class logrotate {	1 class logrotate {

2 exec {'ensure_logrotate_status':	2 exec {'ensure_logrotate_status':

3 command => '/etc/cron.daily/logrotate',	3 command => '/etc/cron.daily/logrotate',

4 path => [ "/usr/bin/", "/bin/" ],	4 path => ["/usr/bin/", "/bin/"],
Felix Dahlke 2013/02/07 15:38:41 Mind getting rid of the whitespace between path an Mind getting rid of the whitespace between path and =>?
5 onlyif => 'test ! -f /var/lib/logrotate/status'	5 onlyif => 'test ! -f /var/lib/logrotate/status'

6 }	6 }

7	7

8 cron {'logrotate':	8 cron {'logrotate':

9 ensure => present,	9 ensure => present,

10 require => [	10 require => Exec['ensure_logrotate_status'],
Felix Dahlke 2013/02/07 15:38:41 Should be fine without the enclosing square bracke Should be fine without the enclosing square brackets: require => Exec[...]
11 Exec['ensure_logrotate_status']

12 ],

13 command => '/usr/sbin/logrotate /etc/logrotate.conf',	11 command => '/usr/sbin/logrotate /etc/logrotate.conf',

14 user => root,	12 user => root,

15 hour => '0',	13 hour => '0',

16 minute => '0'	14 minute => '0'

17 }	15 }

18 }	16 }

LEFT	RIGHT