res/layout/proxyconfiguration.xml - Issue 9433002: ABP/Android Proxy settings user helper

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: res/layout/proxyconfiguration.xml

Issue 9433002: ABP/Android Proxy settings user helper (Closed)

Patch Set: Created Feb. 20, 2013, 8:49 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	3 android:layout_width="wrap_content"

	4 android:layout_height="wrap_content"

	5 android:orientation="vertical"

	6 android:paddingTop="8dip"

	7 android:paddingLeft="16dip"

	8 android:paddingRight="16dip" >

	9

	10 <TextView

	11 android:id="@+id/message_text"

	12 android:layout_width="fill_parent"

	13 android:layout_height="wrap_content" />

	14

	15 <LinearLayout

	16 android:layout_width="fill_parent"

	17 android:layout_height="wrap_content"

	18 android:gravity="center"

	19 android:orientation="horizontal"

	20 android:paddingBottom="16dip">

	21

	22 <Button

	23 android:layout_width="wrap_content"

	24 android:layout_height="wrap_content"

	25 android:onClick="onGotit"

	26 android:paddingRight="8dip"

	27 android:text="@string/gotit" />
	Felix Dahlke 2013/02/22 11:01:54 That button is a bit confusing in fact. Shouldn't That button is a bit confusing in fact. Shouldn't it be "cancel" or something? Andrey Novikov 2013/02/22 11:32:57 No. It does not cancel anything, it just confirms Show quoted text On 2013/02/22 11:01:54, Felix H. Dahlke wrote: > That button is a bit confusing in fact. Shouldn't it be "cancel" or something? No. It does not cancel anything, it just confirms that user knows what to do on its own. Felix Dahlke 2013/02/22 11:39:35 I think it does. You either go forward with the pr Show quoted text On 2013/02/22 11:32:57, Andrey Novikov wrote: > On 2013/02/22 11:01:54, Felix H. Dahlke wrote: > > That button is a bit confusing in fact. Shouldn't it be "cancel" or something? > > No. It does not cancel anything, it just confirms that user knows what to do on > its own. I think it does. You either go forward with the process (which should be what most people want), and let ABP take you to the preference page, or you abort for whatever reason. So cancel, close, abort, something like that.
	28

	29 <Button

	30 android:layout_width="wrap_content"

	31 android:layout_height="wrap_content"

	32 android:onClick="onSettings"

	33 android:text="@string/opensettings" />

	34 </LinearLayout>

	35

	36 </LinearLayout>

OLD	NEW

« no previous file with comments | « res/layout/preferences.xml ('k') | res/raw/proxysettings.txt » ('j') | no next file with comments »