Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: popupBlocker.js

Issue 9763003: Fixed: Pop-ups loading a different page after about:blank aren`t being considered (Closed)
Patch Set: Created March 11, 2013, 11:18 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .hgsubstate ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: popupBlocker.js
===================================================================
--- a/popupBlocker.js
+++ b/popupBlocker.js
@@ -39,17 +39,17 @@ chrome.tabs.onUpdated.addListener(functi
{
// Not a pop-up we've previously seen
return;
}
if ("url" in changeInfo)
checkPotentialPopup(tabId, tab.url, tabsLoading[tabId]);
- if ("status" in changeInfo && changeInfo.status == "complete")
+ if ("status" in changeInfo && changeInfo.status == "complete" && tab.url != "about:blank")
delete tabsLoading[tabId];
});
function checkPotentialPopup(tabId, url, opener)
{
var requestHost = extractHostFromURL(url);
var documentHost = extractHostFromURL(opener);
« no previous file with comments | « .hgsubstate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld