Always use the system language for the UI

Shared/PluginClientBase.cpp

 #include "PluginStdAfx.h"
 
 // Internet / FTP
 #include <wininet.h>
 
 // IP adapter
 #include <iphlpapi.h>
 
 #include "PluginSettings.h"
 #include "PluginSystem.h"
@@ skipping 71 matching lines @@
     url.ReleaseBuffer();
     url = unescapedUrl;
   }
 
   return url;
 }
 
 
 void CPluginClientBase::SetLocalization()
 {
-  CPluginDictionary* dic = CPluginDictionary::GetInstance();
-
   CPluginSystem* system = CPluginSystem::GetInstance();
-
   CString browserLanguage = system->GetBrowserLanguage();
 
+  CPluginDictionary* dic = CPluginDictionary::GetInstance();
+  dic->SetLanguage(browserLanguage);
+
   CPluginSettings* settings = CPluginSettings::GetInstance();
-
-  if (settings->IsMainProcess() && settings->IsMainThread())
+  if (settings->IsMainProcess() && settings->IsMainThread() && !settings->Has(SETTING_LANGUAGE))
   {
-    if (browserLanguage != settings->GetString(SETTING_LANGUAGE))
-    {
-      if (dic->IsLanguageSupported(browserLanguage))
-      {
-        //                          settings->SetString(SETTING_LANGUAGE, browserLanguage);
-      }
-    }
-
-    if (!settings->Has(SETTING_LANGUAGE))
-    {
-      settings->SetString(SETTING_LANGUAGE, "en");
-    }
-
+    settings->SetString(SETTING_LANGUAGE, browserLanguage);

[Oleksandr, 2013/03/22 16:04:14]

What if we don't have the browser's version in the dictionary? The value in the
setting's file would be a bit misleading imho. Maybe we should still default to
"en" more gracefuly? Also, what if the user changes the browser language after
we have initially set it. Shall we change as well?

[Felix Dahlke, 2013/03/22 16:09:18]

Hehe, I've wondered quite a bit about this actually. I thought it's better to
put the actual language into the settings file, but since that's an illegal
value as far as the settings are concerned, it may really be misleading. The
question is: is the result of dic->IsLanguageSupported() actually related to
what _filters_ we offer? I thought not.
No, I don't think so. We select a subscription based on the user's language,
from then on he's on his own. That's how the other extensions do it if I'm not
mistaken.

[Oleksandr, 2013/03/22 16:15:28]

It isn't related, but it's not like we can have one that is related :) I guess
at some point of time we can implement IsLanguageFilterSupported or something
like that. Probably not important right now.
LGTM then

     settings->Write();
   }
-
-  dic->SetLanguage(settings->GetString(SETTING_LANGUAGE));
 }
 
 
 void CPluginClientBase::LogPluginError(DWORD errorCode, int errorId, int errorSubid, const CString& description, bool isAsync, DWORD dwProcessId, DWORD dwThreadId)
 {
   // Prevent circular references
   if (CPluginSettings::HasInstance() && isAsync)
   {
     DEBUG_ERROR_CODE_EX(errorCode, description, dwProcessId, dwThreadId);
 
@@ skipping 110 matching lines @@
 {
   m_criticalSectionWhitelist.Lock();
   {
     m_cacheWhitelistedUrls.clear();
   }
   m_criticalSectionWhitelist.Unlock();
 }
 
 
 #endif // SUPPORT_WHITELIST