include/AdblockPlus.h - Issue 9987009: Interface for the libadblockplus API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: include/AdblockPlus.h

Issue 9987009: Interface for the libadblockplus API (Closed)

Left Patch Set: Created March 26, 2013, 11:45 a.m.

Right Patch Set: Reduce redundant redundancy Created March 27, 2013, 6:45 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #ifndef ADBLOCKPLUS_H	1 #ifndef ADBLOCKPLUS_H
Oleksandr 2013/03/27 08:37:01 Do you think we could rename this file? To abpv8.h Do you think we could rename this file? To abpv8.h or something like that. We already have one AdblockPlus.h in IE and I'm sure we have one in each of our other projects.. Felix Dahlke 2013/03/27 08:59:17 That shouldn't cause any trouble if we don't put i Show quoted text On 2013/03/27 08:37:01, Oleksandr wrote: > Do you think we could rename this file? To abpv8.h or something like that. We > already have one AdblockPlus.h in IE and I'm sure we have one in each of our > other projects.. That shouldn't cause any trouble if we don't put include/AdblockPlus in the include path, but only include. Then we'd have #include <AdblockPlus/AdblockPlus.h>. Should actually work regardless with <AdblockPlus.h> I think. What could cause an issue is the include guard though. I'll prefix them all, but in a separate review.
2 #define ADBLOCKPLUS_H	2 #define ADBLOCKPLUS_H

3	3

4 #include <AdblockPlus/FileReader.h>	4 #include <AdblockPlus/FileReader.h>

	5 #include <AdblockPlus/FilterEngine.h>

5 #include <AdblockPlus/ErrorCallback.h>	6 #include <AdblockPlus/ErrorCallback.h>

6 #include <AdblockPlus/JsEngine.h>	7 #include <AdblockPlus/JsEngine.h>

7 #include <AdblockPlus/AdblockPlus.h>

8	8

9 #endif	9 #endif

LEFT	RIGHT