libadblockplus.gyp - Issue 9987009: Interface for the libadblockplus API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: libadblockplus.gyp

Issue 9987009: Interface for the libadblockplus API (Closed)

Left Patch Set: Rename to FilterEngine, add a dummy implementation Created March 26, 2013, 1:50 p.m.

Right Patch Set: Reduce redundant redundancy Created March 27, 2013, 6:45 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 'includes': ['third_party/v8/build/common.gypi',	2 'includes': ['third_party/v8/build/common.gypi',

3 'shell/shell.gyp'],	3 'shell/shell.gyp'],

4 'targets': [{	4 'targets': [{

5 'target_name': 'libadblockplus',	5 'target_name': 'libadblockplus',

6 'type': '<(library)',	6 'type': '<(library)',

7 'include_dirs': [	7 'include_dirs': [

8 'include',	8 'include',

9 'third_party/v8/include'	9 'third_party/v8/include'

10 ],	10 ],

(...skipping 12 matching lines...) Expand all Loading...
23 },	23 },

24 {	24 {

25 'target_name': 'tests',	25 'target_name': 'tests',

26 'type': 'executable',	26 'type': 'executable',

27 'dependencies': [	27 'dependencies': [

28 'third_party/googletest.gyp:googletest_main',	28 'third_party/googletest.gyp:googletest_main',

29 'libadblockplus'	29 'libadblockplus'

30 ],	30 ],

31 'sources': [	31 'sources': [

32 'test/ConsoleJsObject.cpp',	32 'test/ConsoleJsObject.cpp',

	33 'test/FilterEngineStubs.cpp',

33 'test/JsEngine.cpp'	34 'test/JsEngine.cpp'

34 ]	35 ]

35 }]	36 }]

36 }	37 }

LEFT	RIGHT