Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10008015: Move global JS object creation to a separate namespace (Closed)

Created:
April 3, 2013, 12:33 p.m. by Felix Dahlke
Modified:
April 3, 2013, 12:39 p.m.
Reviewers:
Wladimir Palant
CC:
Oleksandr
Visibility:
Public.

Description

The whole one-namespace-per-JS-object pattern is not exactly a masterpiece of software architecture, but I still think it's better to move the global object to its own namespace, as it's going to get a bit more crowded now. Once we've implemented all the API we need, we can think of a better method of creating JS objects.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M libadblockplus.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A src/GlobalJsObject.h View 1 chunk +14 lines, -0 lines 0 comments Download
A src/GlobalJsObject.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M src/JsEngine.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2
Felix Dahlke
April 3, 2013, 12:35 p.m. (2013-04-03 12:35:45 UTC) #1
Wladimir Palant
April 3, 2013, 12:38 p.m. (2013-04-03 12:38:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld