Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10011043: Move ABP JS code loading to FilterEngine and make it optional (Closed)

Created:
April 2, 2013, 10:32 a.m. by Felix Dahlke
Modified:
Nov. 12, 2013, 10:09 a.m.
Visibility:
Public.

Description

This contains two changes: 1. Load the ABP JS code in FilterEngine instead of JsEngine, since it kinda belongs there now. 2. Make the JS loading optional, and actually don't do it by default, since it doesn't work yet. I added the define FILTER_ENGINE_STUBS for that. As the README says, to use the proper Adblock Plus and not the stubs, this'll do: make test CXXFLAGS="-DFILTER_ENGINE_STUBS=0" We can obviously get rid of that and the stubs at some point.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M README.md View 1 chunk +6 lines, -0 lines 0 comments Download
M libadblockplus.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/FilterEngine.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M src/JsEngine.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3
Felix Dahlke
April 2, 2013, 10:37 a.m. (2013-04-02 10:37:29 UTC) #1
Wladimir Palant
LGTM
April 3, 2013, 12:10 p.m. (2013-04-03 12:10:08 UTC) #2
Oleksandr
April 3, 2013, 12:18 p.m. (2013-04-03 12:18:46 UTC) #3
On 2013/04/03 12:10:08, Wladimir Palant wrote:
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld