Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10124007: Thread-safe JS execution (Closed)

Created:
April 5, 2013, 1:35 p.m. by Felix Dahlke
Modified:
April 8, 2013, 3:08 p.m.
Reviewers:
Wladimir Palant
CC:
Oleksandr
Visibility:
Public.

Description

It may not look like much, but I literally had to reverse engineer V8 to figure out how to do this. I have not included tests for the thread safety as tests for other things like setTimeout will cover this.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/GlobalJsObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/JsEngine.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Felix Dahlke
It may not look like much, but I literally had to reverse engineer V8 to ...
April 5, 2013, 1:37 p.m. (2013-04-05 13:37:43 UTC) #1
Felix Dahlke
April 5, 2013, 1:37 p.m. (2013-04-05 13:37:52 UTC) #2
Wladimir Palant
April 5, 2013, 1:53 p.m. (2013-04-05 13:53:34 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld