Issue 10184021: Some refactoring of global JavaScript objects

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10184021: Some refactoring of global JavaScript objects (Closed)

Created:
April 15, 2013, 2:54 p.m. by Wladimir Palant

Modified:
May 7, 2013, 7:36 a.m.

Reviewers:
Felix Dahlke, Oleksandr

Visibility:
Public.

Description

This started out as a crash fix in setTimeout (context wasn`t being propagated) but I ended up making these objects use new JsValue API wherever possible.

Patch Set 1 #

Patch Set 2 : Unbitrotted patch #

Created: April 16, 2013, 3:32 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+263 lines, -275 lines)			Patch
M	include/AdblockPlus/JsEngine.h	View	1	1 chunk	+19 lines, -1 line	0 comments	Download
M	include/AdblockPlus/JsValue.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/AdblockPlus/WebRequest.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ConsoleJsObject.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ConsoleJsObject.cpp	View		1 chunk	+12 lines, -14 lines	0 comments	Download
M	src/FileSystemJsObject.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/FileSystemJsObject.cpp	View	1	6 chunks	+94 lines, -128 lines	0 comments	Download
M	src/GlobalJsObject.h	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/GlobalJsObject.cpp	View	1	1 chunk	+23 lines, -43 lines	0 comments	Download
M	src/JsEngine.cpp	View	1	4 chunks	+28 lines, -8 lines	0 comments	Download
M	src/JsValue.cpp	View		3 chunks	+29 lines, -0 lines	0 comments	Download
M	src/WebRequestJsObject.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/WebRequestJsObject.cpp	View		1 chunk	+36 lines, -68 lines	0 comments	Download
M	test/GlobalJsObject.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	test/JsEngine.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/JsValue.cpp	View		6 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages