Issue 10227005: Collect <meta> tags at top of <head> to fix issue with Facebook's Open Graph parsing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10227005: Collect <meta> tags at top of <head> to fix issue with Facebook's Open Graph parsing (Closed)

Created:
April 10, 2013, 10:52 a.m. by Thomas Greiner

Modified:
April 11, 2013, 8:20 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Facebook's parser ignores <meta> tags in <head> if it previously encountered a <noscript> tag which makes it treat those tags as part of <body>. This change moves all <meta> tags (independent of their position on the page) to the top of <head> to prevent <noscript> tags from being on top of a <meta> tag. Previously only those in <body> were moved to the bottom of <head>.

Patch Set 1 #

Created: April 10, 2013, 10:52 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	anwiki/_override/global/global/global.tpl.php	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

LGTM, but that's one mean regex right there :D

Expand All Messages | Collapse All Messages