Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10236010: Always work with pointers to filters and subscriptions, drop the references for API consistency (Closed)

Created:
April 11, 2013, 7:24 a.m. by Wladimir Palant
Modified:
April 11, 2013, 8:37 a.m.
Reviewers:
Felix Dahlke, Oleksandr
Visibility:
Public.

Description

Always work with pointers to filters and subscriptions, drop the references for API consistency

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -75 lines) Patch
M include/AdblockPlus/FilterEngine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/src/FiltersCommand.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M shell/src/SubscriptionsCommand.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/FilterEngine.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
M test/FilterEngineStubs.cpp View 1 chunk +46 lines, -46 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
April 11, 2013, 7:24 a.m. (2013-04-11 07:24:24 UTC) #1
Felix Dahlke
LGTM
April 11, 2013, 7:32 a.m. (2013-04-11 07:32:05 UTC) #2
Oleksandr
April 11, 2013, 7:32 a.m. (2013-04-11 07:32:38 UTC) #3
On 2013/04/11 07:24:24, Wladimir Palant wrote:

LGTM

Powered by Google App Engine
This is Rietveld