Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/ConsoleJsObject.cpp

Issue 10252009: Support multiple arguments properly in console.error (Closed)
Patch Set: Created April 11, 2013, 10:59 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ConsoleJsObject.h ('k') | test/ConsoleJsObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ConsoleJsObject.cpp
===================================================================
--- a/src/ConsoleJsObject.cpp
+++ b/src/ConsoleJsObject.cpp
@@ -1,3 +1,4 @@
+#include <AdblockPlus/ErrorCallback.h>
#include <sstream>
#include "ConsoleJsObject.h"
@@ -10,7 +11,7 @@
const v8::HandleScope handleScope;
for (int i = 0; i < arguments.Length(); i++)
{
- const v8::Handle<v8::Value> argument = arguments[0];
+ const v8::Handle<v8::Value> argument = arguments[i];
const v8::String::Utf8Value value(argument);
message << *value;
}
« no previous file with comments | « src/ConsoleJsObject.h ('k') | test/ConsoleJsObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld