Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10252009: Support multiple arguments properly in console.error (Closed)

Created:
April 11, 2013, 10:59 a.m. by Felix Dahlke
Modified:
April 12, 2013, 3:20 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Since you found the issue, you can review the fix :) I moved an include from header to implementation while I was at it.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/ConsoleJsObject.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ConsoleJsObject.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M test/ConsoleJsObject.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Felix Dahlke
April 11, 2013, 11:06 a.m. (2013-04-11 11:06:58 UTC) #1
Wladimir Palant
April 11, 2013, 5:54 p.m. (2013-04-11 17:54:24 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld