Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: shell/src/MatchesCommand.cpp

Issue 10254076: API cleanup, get rid of JsObject and GetProperty() methods that don`t return JsValue (Closed)
Patch Set: Slightly better Filter/Subscription constructors Created April 26, 2013, 11:51 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/src/FiltersCommand.cpp ('k') | shell/src/SubscriptionsCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/src/MatchesCommand.cpp
===================================================================
--- a/shell/src/MatchesCommand.cpp
+++ b/shell/src/MatchesCommand.cpp
@@ -21,20 +21,20 @@ void MatchesCommand::operator()(const st
{
ShowUsage();
return;
}
AdblockPlus::FilterPtr match = filterEngine.Matches(url, contentType, documentUrl);
if (!match)
std::cout << "No match" << std::endl;
- else if (match->GetProperty("type", "") == "exception")
- std::cout << "Whitelisted" << std::endl;
+ else if (match->GetType() == AdblockPlus::Filter::TYPE_EXCEPTION)
+ std::cout << "Whitelisted by " << match->GetProperty("text")->AsString() << std::endl;
else
- std::cout << "Blocked" << std::endl;
+ std::cout << "Blocked by " << match->GetProperty("text")->AsString() << std::endl;
}
std::string MatchesCommand::GetDescription() const
{
return "Returns the first filter that matches the supplied URL";
}
std::string MatchesCommand::GetUsage() const
« no previous file with comments | « shell/src/FiltersCommand.cpp ('k') | shell/src/SubscriptionsCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld