Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10254076: API cleanup, get rid of JsObject and GetProperty() methods that don`t return JsValue (Closed)

Created:
April 26, 2013, 11:41 a.m. by Wladimir Palant
Modified:
April 29, 2013, 11:29 a.m.
Reviewers:
Felix Dahlke, Oleksandr
Visibility:
Public.

Description

API cleanup, get rid of JsObject and GetProperty() methods that don`t return JsValue

Patch Set 1 #

Patch Set 2 : Slightly better Filter/Subscription constructors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -102 lines) Patch
M include/AdblockPlus/FilterEngine.h View 1 chunk +3 lines, -21 lines 0 comments Download
M include/AdblockPlus/JsValue.h View 1 1 chunk +1 line, -1 line 0 comments Download
M shell/src/FiltersCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M shell/src/MatchesCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M shell/src/SubscriptionsCommand.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M src/FilterEngine.cpp View 1 3 chunks +20 lines, -49 lines 0 comments Download
M src/JsValue.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/FilterEngine.cpp View 3 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
April 26, 2013, 11:41 a.m. (2013-04-26 11:41:06 UTC) #1
Felix Dahlke
April 29, 2013, 11:03 a.m. (2013-04-29 11:03:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld