Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/GlobalJsObject.cpp

Issue 10260028: Refactor tests, use fixtures and avoid duplication (Closed)
Patch Set: Created April 19, 2013, 4:11 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/FilterEngine.cpp ('k') | test/JsEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/GlobalJsObject.cpp
===================================================================
--- a/test/GlobalJsObject.cpp
+++ b/test/GlobalJsObject.cpp
@@ -1,36 +1,37 @@
-#include <AdblockPlus.h>
-#include <gtest/gtest.h>
-
+#include "BaseJsTest.h"
#include "../src/Thread.h"
-TEST(GlobalJsObjectTest, SetTimeout)
+namespace
{
- AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
+ class GlobalJsObjectTest : public BaseJsTest
+ {
+ };
+}
+
+TEST_F(GlobalJsObjectTest, SetTimeout)
+{
jsEngine->Evaluate("setTimeout(function() {foo = 'bar';}, 100)");
ASSERT_TRUE(jsEngine->Evaluate("this.foo")->IsUndefined());
AdblockPlus::Sleep(200);
ASSERT_EQ("bar", jsEngine->Evaluate("this.foo")->AsString());
}
-TEST(GlobalJsObjectTest, SetTimeoutWithArgs)
+TEST_F(GlobalJsObjectTest, SetTimeoutWithArgs)
{
- AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
jsEngine->Evaluate("setTimeout(function(s) {foo = s;}, 100, 'foobar')");
ASSERT_TRUE(jsEngine->Evaluate("this.foo")->IsUndefined());
AdblockPlus::Sleep(200);
ASSERT_EQ("foobar", jsEngine->Evaluate("this.foo")->AsString());
}
-TEST(GlobalJsObjectTest, SetTimeoutWithInvalidArgs)
+TEST_F(GlobalJsObjectTest, SetTimeoutWithInvalidArgs)
{
- AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
ASSERT_ANY_THROW(jsEngine->Evaluate("setTimeout()"));
ASSERT_ANY_THROW(jsEngine->Evaluate("setTimeout('', 1)"));
}
-TEST(GlobalJsObjectTest, SetMultipleTimeouts)
+TEST_F(GlobalJsObjectTest, SetMultipleTimeouts)
{
- AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
jsEngine->Evaluate("foo = []");
jsEngine->Evaluate("setTimeout(function(s) {foo.push('1');}, 100)");
jsEngine->Evaluate("setTimeout(function(s) {foo.push('2');}, 150)");
« no previous file with comments | « test/FilterEngine.cpp ('k') | test/JsEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld