Issue 10260028: Refactor tests, use fixtures and avoid duplication

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10260028: Refactor tests, use fixtures and avoid duplication (Closed)

Created:
April 19, 2013, 2:38 p.m. by Felix Dahlke

Modified:
April 29, 2013, 9:39 a.m.

Reviewers:
Wladimir Palant

CC:
Oleksandr

Visibility:
Public.

Description

This also makes the tests a bit better, since the default JsEngine instance used by all tests throws exceptions when any unexpected errors are logged or any unexpected I/O is done. There's still a big TODO in FilterEngine, which actually logs a couple of errors and does a bit of I/O right now. I'm planning to remedy that, but I think it's worth doing in a separate review. Please ignore the project file changes involving FILTER_ENGINE_STUBS.

Patch Set 1 : #

Created: April 19, 2013, 4:11 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+276 lines, -257 lines)			Patch
M	MSVS/libadblockplus.vcxproj	View	1 chunk	+1 line, -1 line	0 comments	Download
M	MSVS/tests.vcxproj	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	MSVS/tests.vcxproj.filters	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	test/BaseJsTest.h	View	1 chunk	+67 lines, -0 lines	0 comments	Download
M	test/ConsoleJsObject.cpp	View	1 chunk	+35 lines, -24 lines	0 comments	Download
M	test/FileSystemJsObject.cpp	View	5 chunks	+47 lines, -69 lines	0 comments	Download
M	test/FilterEngine.cpp	View	3 chunks	+56 lines, -91 lines	0 comments	Download
M	test/GlobalJsObject.cpp	View	1 chunk	+12 lines, -11 lines	0 comments	Download
M	test/JsEngine.cpp	View	2 chunks	+10 lines, -21 lines	0 comments	Download
M	test/JsValue.cpp	View	9 chunks	+17 lines, -20 lines	0 comments	Download
M	test/WebRequest.cpp	View	3 chunks	+22 lines, -19 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Nice cleanup, LGTM

Expand All Messages | Collapse All Messages