Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10291009: Disable side-effects in filter engine tests (Closed)

Created:
April 26, 2013, 12:14 p.m. by Wladimir Palant
Modified:
April 29, 2013, 11:31 a.m.
Reviewers:
Felix Dahlke, Oleksandr
Visibility:
Public.

Description

Disable side-effects in filter engine tests

Patch Set 1 #

Patch Set 2 : Fixed the other TODO in tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -27 lines) Patch
M test/BaseJsTest.h View 1 2 chunks +48 lines, -0 lines 0 comments Download
M test/FilterEngine.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/WebRequest.cpp View 1 2 chunks +21 lines, -25 lines 2 comments Download

Messages

Total messages: 6
Wladimir Palant
April 26, 2013, 12:14 p.m. (2013-04-26 12:14:44 UTC) #1
Oleksandr
Doesn't look too pretty, but seeing I can't come up with a better solution and ...
April 26, 2013, 12:39 p.m. (2013-04-26 12:39:05 UTC) #2
Wladimir Palant
I fixed another TODO in tests that required moving LazyFileSystem into BaseJsTest (I moved LazyWebRequest ...
April 26, 2013, 12:45 p.m. (2013-04-26 12:45:45 UTC) #3
Oleksandr
LGTM http://codereview.adblockplus.org/10291009/diff/4001/test/WebRequest.cpp File test/WebRequest.cpp (right): http://codereview.adblockplus.org/10291009/diff/4001/test/WebRequest.cpp#newcode23 test/WebRequest.cpp:23: template<class T> Miht be a good idea to ...
April 26, 2013, 1:10 p.m. (2013-04-26 13:10:01 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/10291009/diff/4001/test/WebRequest.cpp File test/WebRequest.cpp (right): http://codereview.adblockplus.org/10291009/diff/4001/test/WebRequest.cpp#newcode23 test/WebRequest.cpp:23: template<class T> I tend to resist making code more ...
April 26, 2013, 1:12 p.m. (2013-04-26 13:12:57 UTC) #5
Felix Dahlke
April 29, 2013, 10:07 a.m. (2013-04-29 10:07:04 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld