Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10295007: Added "learn more" toggle and area for platform-specific content (Closed)

Created:
April 15, 2013, 1:49 p.m. by Thomas Greiner
Modified:
April 24, 2013, 10:47 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Added "learn more" toggle and area for platform-specific content

Patch Set 1 #

Total comments: 1

Patch Set 2 : Hide "learn more" button if JavaScript disabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -1 line) Patch
M anwiki/_override-static/global/global/css/index.css View 2 chunks +89 lines, -1 line 0 comments Download
M anwiki/_override-static/global/global/css/index-desktop.css View 2 chunks +37 lines, -0 lines 0 comments Download
M anwiki/_override-static/global/global/css/index-mobile.css View 1 chunk +17 lines, -0 lines 0 comments Download
M anwiki/_override-static/global/global/css/main.css View 1 chunk +1 line, -0 lines 0 comments Download
M anwiki/_override-static/global/global/css/noscript-desktop.css View 1 1 chunk +5 lines, -0 lines 0 comments Download
A anwiki/_override-static/global/global/js/index.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Thomas Greiner
Styles and behavior of new content area for homepage. Actual content needs to be added ...
April 19, 2013, 8:56 a.m. (2013-04-19 08:56:42 UTC) #1
Felix Dahlke
LGTM, assuming this has been tested in all the browsers we want to support and ...
April 22, 2013, 2:55 p.m. (2013-04-22 14:55:56 UTC) #2
Thomas Greiner
April 23, 2013, 9:19 a.m. (2013-04-23 09:19:46 UTC) #3
I hid the "learn more" button now but we may want to revisit this in the future
because there are a couple of possibilities on how to tackle visitors who have
disabled JavaScript:
- show button and keep tabs hidden (previous)
- hide button and keep tabs hidden (current)
- hide button and show all tabs
- add link to button which leads to some other page where they can learn more

In any case this should be done in a new review and should not further delay
this one.

Powered by Google App Engine
This is Rietveld