Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10405034: Add a method to check whether ABP is fully initialised (Closed)

Created:
May 15, 2013, 2:55 p.m. by Felix Dahlke
Modified:
May 17, 2013, 8:43 a.m.
Reviewers:
Wladimir Palant
CC:
Oleksandr
Visibility:
Public.

Description

This allows clients to wait until ABP is fully initialised, which is necessary for adding subscriptions. I'm aware that this is not what you had in mind Wladimir, it would be cleaner to just pass the user language in through AppInfo and select an appropriate default subscription in libadblockplus. However, it would also take a bit longer to implement. Would you mind going with this for now?

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M include/AdblockPlus/FilterEngine.h View 1 chunk +1 line, -0 lines 0 comments Download
A lib/init.js View 1 chunk +8 lines, -0 lines 0 comments Download
M libadblockplus.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/FilterEngine.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M test/FilterEngine.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Felix Dahlke
May 15, 2013, 2:59 p.m. (2013-05-15 14:59:11 UTC) #1
Wladimir Palant
Mostly LGTM, we need this API regardless of the subscription adding approach. However, we also ...
May 15, 2013, 3:51 p.m. (2013-05-15 15:51:59 UTC) #2
Felix Dahlke
On 2013/05/15 15:51:59, Wladimir Palant wrote: > Mostly LGTM, we need this API regardless of ...
May 16, 2013, 2:50 a.m. (2013-05-16 02:50:18 UTC) #3
Wladimir Palant
On 2013/05/16 02:50:18, Felix H. Dahlke wrote: > We could have a callback that's invoked ...
May 16, 2013, 11:54 a.m. (2013-05-16 11:54:28 UTC) #4
Wladimir Palant
Alternatively we can simply make FilterEngine constructor wait until everything is initialized and only return ...
May 16, 2013, 12:15 p.m. (2013-05-16 12:15:30 UTC) #5
Felix Dahlke
May 17, 2013, 8:43 a.m. (2013-05-17 08:43:51 UTC) #6
On 2013/05/16 12:15:30, Wladimir Palant wrote:
> Alternatively we can simply make FilterEngine constructor wait until
everything
> is initialized and only return then.

Closing this review, since you addressed that in a new one:
http://codereview.adblockplus.org/10420020/

Powered by Google App Engine
This is Rietveld