Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/LogSystem.h

Issue 10524054: Rename ErrorCallback into LogSystem, provide a proper console API (Closed)
Patch Set: Created May 10, 2013, 2:01 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | libadblockplus.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #ifndef ADBLOCK_PLUS_ERROR_CALLBACK_H 18 #ifndef ADBLOCK_PLUS_LOG_SYSTEM_H
19 #define ADBLOCK_PLUS_ERROR_CALLBACK_H 19 #define ADBLOCK_PLUS_LOG_SYSTEM_H
20 20
21 #include <string> 21 #include <string>
22 22
23 #include "tr1_memory.h" 23 #include "tr1_memory.h"
24 24
25 namespace AdblockPlus 25 namespace AdblockPlus
26 { 26 {
27 class ErrorCallback 27 class LogSystem
28 { 28 {
29 public: 29 public:
30 virtual ~ErrorCallback(); 30 enum LogLevel {TRACE, LOG, INFO, WARN, ERROR};
Felix Dahlke 2013/05/13 07:20:15 The common approach is to prefix enum values with
31 virtual void operator()(const std::string& message) = 0; 31
32 virtual ~LogSystem() {}
33 virtual void operator()(LogLevel logLevel, const std::string& message,
34 const std::string& source) = 0;
32 }; 35 };
33 36
34 typedef std::tr1::shared_ptr<ErrorCallback> ErrorCallbackPtr; 37 typedef std::tr1::shared_ptr<LogSystem> LogSystemPtr;
35 } 38 }
36 39
37 #endif 40 #endif
OLDNEW
« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | libadblockplus.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld