Issue 10524054: Rename ErrorCallback into LogSystem, provide a proper console API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10524054: Rename ErrorCallback into LogSystem, provide a proper console API (Closed)

Created:
May 10, 2013, 2:01 p.m. by Wladimir Palant

Modified:
May 13, 2013, 8:10 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Rename ErrorCallback into LogSystem, provide a proper console API

Patch Set 1 #

Total comments: 1

Created: May 10, 2013, 2:01 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+189 lines, -79 lines)			Patch
M	include/AdblockPlus.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	include/AdblockPlus/DefaultLogSystem.h	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	include/AdblockPlus/JsEngine.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	include/AdblockPlus/LogSystem.h	View	1 chunk	+9 lines, -6 lines	1 comment	Download
M	libadblockplus.gyp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/AppInfoJsObject.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ConsoleJsObject.cpp	View	1 chunk	+67 lines, -4 lines	0 comments	Download
M	src/DefaultLogSystem.cpp	View	1 chunk	+24 lines, -3 lines	0 comments	Download
R	src/ErrorCallback.cpp	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	src/JsEngine.cpp	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	test/BaseJsTest.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	test/ConsoleJsObject.cpp	View	1 chunk	+59 lines, -14 lines	0 comments	Download
M	test/FilterEngine.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/JsEngine.cpp	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Felix Dahlke

May 13, 2013, 7:20 a.m. (2013-05-13 07:20:15 UTC) #2

LGTM

http://codereview.adblockplus.org/10524054/diff/1/include/AdblockPlus/LogSyst...
File include/AdblockPlus/LogSystem.h (right):

http://codereview.adblockplus.org/10524054/diff/1/include/AdblockPlus/LogSyst...
include/AdblockPlus/LogSystem.h:30: enum LogLevel {TRACE, LOG, INFO, WARN,
ERROR};
The common approach is to prefix enum values with the enum name, e.g.:
LOG_LEVEL_TRACE. Oleksandr has already changes this as it didn't compile on
Windows.

Expand All Messages | Collapse All Messages